It seems that using the system block style, I can not get the title of my content panes to disappear.

On the pane settings form I have checked the box to "override title" and typed < none > in the box, but the title still shows.

I then went to block settings (ew!) and also configured the blocks to have their titles hidden, just incase the block style pulled the setting from block settings instead of pane settings, but the titles still show on the panes.

Is it possible to hide pane titles when using the default "system block" style? I think I remember this working in the past, perhaps a new bug.

(It looks like the "Override title" setting *does* work if all you want to do is change the title - it's just the "none" that doesn't seem to work.)

edit: it looks like the "none" does still work when using "No style".

CommentFileSizeAuthor
#11 panels-1397076-hide-pane-title-11.patch474 bytesvijaycs85
#8 panels-remove_empty_title_check-1397076-8.patch575 bytesjenlampton
#2 remove_empty_title_check-1397076-2.patch464 bytesjenlampton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

Oh this is probably because blocks use $block->subject and panes use $block->title -- maybe if the title is empty it doesn't get moved to subject and the original title sticks or something.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Active » Needs review
FileSize
remove_empty_title_check-1397076-2.patch464 bytes

That sounds about right.

I found an 

if (!empty($content->title))

Which looks like it prevents an empty title from becoming an empty subject.
Is there any harm in removing that check entirely?

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

That might cause a fail if override title is NOT checked?

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Status: Needs review » Needs work
jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Version: 6.x-3.x-dev » 6.x-3.9

- Overriding the title with text works as expected.
- Overriding the title with "none" removes the title.
- Not overriding the title lets the block subject show through.

What else should I test to get this possible error?

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Version: 6.x-3.9 » 6.x-3.x-dev
Status: Needs work » Needs review

patch still applies to latest version of panels.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Version: 6.x-3.9 » 6.x-3.x-dev

still adding this patch to every site I deploy with panels (and that's all of them) :)

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
FileSize
panels-remove_empty_title_check-1397076-8.patch575 bytes

Patch stopped applying cleanly. rerolled.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

There's a different patch in http://drupal.org/node/1912174 for D7 (probably this one never gets seen because I have not been paying much attention to D6 lately, sadly)

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Issue summary: View changes

added results of more testing

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Issue summary: View changes
Parent issue: » #1774796: Plan for Panels v6.x-3.11 release (PHP 5.4 fix)
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
panels-1397076-hide-pane-title-11.patch474 bytes

Port back of D7 patch in #1912174: Notice: Undefined property: stdClass::$subject

Sharique’s picture

Sharique CreditAttribution: Sharique commented
Status: Needs review » Reviewed & tested by the community

The patch looks good to me.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented
Status: Reviewed & tested by the community » Needs work

Doesn't appear to work in d6.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: #1774796: Plan for Panels v6.x-3.11 release (PHP 5.4 fix) » #2639478: Plan for Panels 6.x-3.12 release

Bumping to the next release.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented
Status: Needs work » Closed (won't fix)

No one replied, not getting fixed.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development for Dog Star Daily commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Closed (won't fix) » Reviewed & tested by the community

The patch in #11 is working for me on Drupal 7.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2850154: Plan for Panels 7.x-3.10
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

retriggered tests

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Reviewed & tested by the community » Closed (outdated)

If you're using the latest dev release of panels 7.x-3.x you should no longer need this patch.

if you experience this issue, please upgrade to the latest dev 7.x-3.x dev release or the next stable release hopefully soon.