Behaviors are not instantiated properly [#1427040]

There are numerous issues around behavior instantiation:

The constructor of the behavior gets passed $field and (sometimes) $instance, but we cache the behaviors per class in _entityreference_get_behavior_handler()
EntityReference_BehaviorHandler_Abstract::__construct() tries to load the settings from a bogus array keys, and as a consequence $this->settings is always empty
We pass $field and $instance to the constructor, but we also pass those to every method. We should do one or the other, not both

Comment	File	Size	Author
#4	1427040-instantiate-behavior.patch	7.2 KB	Damien Tournoud
#4
#2	1427040-instantiate-behavior-er-2.patch	2.33 KB	amitaibu
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 4 February 2012 at 20:24

I'll give it a shot.

Comment #2

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 4 February 2012 at 20:32

Status:

Active

» Needs review

File	Size
1427040-instantiate-behavior-er-2.patch	2.33 KB

> We pass $field and $instance to the constructor, but we also pass those to every method.

Let's keep passing the $field and $instance to all the field modules methods , e.g load(), persave(), to keep the function signature consistent. To our own methods, e.g. access() - I've remove them.

Comment #3

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 February 2012 at 15:25

Because we need to pass $field and $instance to the field methods, I would prefer to pass $field and/or $instance to every methods. Any objection?

Comment #4

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 February 2012 at 15:33

File	Size
1427040-instantiate-behavior.patch	7.2 KB

Proposed patch.

Comment #5

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 February 2012 at 15:51

Status:

Needs review

» Fixed

I actually pushed this by mistake, but I don't see how it could not work for OG (of course it is a slight API change, but the current behavior is completely broken).