Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Media module (and core too) makes use of a.button as links that should look like buttons. These currently appear just as normal links when used with Zen.
Comment | File | Size | Author |
---|---|---|---|
#1 | zen-1420476-1.patch | 406 bytes | maartenverbaarschot |
Comments
Comment #1
maartenverbaarschot CreditAttribution: maartenverbaarschot commentedhow about this..
Comment #2
JohnAlbinBefore and after screenshots or instructions how to test this would be appreciated.
Comment #3
JohnAlbinBlargh. I hate when I have to rename components.
Comment #4
JohnAlbinThe only core styling I see for
.button
is:So how is Zen broken in this regard? We're not overriding a core style or media module's styles.
They appear unstyled in ALL themes if I'm not mistaken. Are you wanting to patch every contributed theme to add button styling for media module?
Comment #5
Dave ReidIt's used extensively by Media module and is definitely something that we're encountering more often, especially with things like Twitter Bootstrap which uses
a.btn
.Please consider that core does actually style this often:
Comment #6
Dave ReidComment #7
JohnAlbinI didn't explain myself well. I don't need a list of places where core themes are doing styling.
I don't know where in core modules it is being used. I can see that none of core's modules are providing styling for a.button, but I don't which modules are actually outputting that markup. It seems like a core bug to be printing something like
<a href="#" class="button>
and expecting every theme in the world to style that.In addition to the actual CSS, Zen has a habit of documenting what the styling applies to. Right now, I don't know what to add as a code comment.
Comment #8
Dave ReidYeah the problem is that core doesn't use it except for on the dashboard UI (see dashboard.js and Drupal.behaviors.dashboard.setupDrawer. It's mostly used in contrib because we can't easily do theme_button and actually get output as
<button ...>
that is not<input type="submit" ...>
Comment #9
Dave ReidComment #10
JohnAlbinThere's a patch that needs work. :-)
We should use this in the Sass version: http://compass-style.org/reference/compass/css3/appearance/
And add this change to the forms stylesheets.
Comment #11
Dave ReidGah, had a brain fart and didn't see the patch in #1.
Comment #12
JohnAlbinFixed. http://drupalcode.org/project/zen.git/commitdiff/3288bff