I think it's wrong to name the id of the wrapper for content and sidebars to "page" semantics-wise. The page is the whole page template.

I propose two solutions:

  1. Rename page to main
  2. Rename page to main and add a wrapper around all content named page.
CommentFileSizeAuthor
#2 tao-927578-rename-and-wrapper_2.patch5.07 KBptrl
#1 tao-927578-rename.patch653 bytesptrl
#1 tao-927578-rename-and-wrapper.patch5.11 KBptrl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ptrl’s picture

ptrl CreditAttribution: ptrl commented
FileSize
tao-927578-rename-and-wrapper.patch5.11 KB
tao-927578-rename.patch653 bytes
ptrl’s picture

ptrl CreditAttribution: ptrl commented
FileSize
tao-927578-rename-and-wrapper_2.patch5.07 KB

patch tao-927578-rename-and-wrapper.patch missing newline at end of file

barraponto’s picture

barraponto CreditAttribution: barraponto commented
Status: Active » Postponed

I like it, and if I were a mantainer, I'd go with #main for 7.x-4.x. I wouldn't like to break all of the child themes that expect a #page id in page.tpl.php. But truth is #main is the content+sidebars wrapper in system.module and Zen, and I'd expect it in Tao as well.

But no #page wrapper, it just doesn't make sense. Use the body tag.