Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a warning when using PHP 5.3.
Attached patch
Comment | File | Size | Author |
---|---|---|---|
#13 | swftools-php53-907464-13.patch | 4.53 KB | somersoft |
#12 | swftools-php53-907464-12.patch | 4.54 KB | somersoft |
#11 | swftools_php53.patch | 7.67 KB | EugenMayer |
#7 | swftools-php53-907464-7.patch | 4.58 KB | Volx |
#4 | swftools-php53.patch | 4.25 KB | John Franklin |
Comments
Comment #1
mr.baileysI can confirm the bug, and victorcoder's approach is the correct one: since $methods and $vars are objects and objects are always passed by reference, there is no need to prefix the those parameters with the reference sign, and doing so will throw a warning on PHP 5.3.
The patch did not apply though, since it wasn't rolled from the module's root. Re-rolled patch attached.
Comment #2
jduhls CreditAttribution: jduhls commentedWorked! Thanks!
Comment #3
John Franklin CreditAttribution: John Franklin commentedHere is a similar patch to update all the submodules as well. Created against 6.x-2.5.
Comment #4
John Franklin CreditAttribution: John Franklin commentedOops... didn't get the &$vars in the last one. Re-rolled.
Comment #5
Stuart Greenfield CreditAttribution: Stuart Greenfield commentedThis is fixed on DRUPAL-6--3.
Next release will be from that branch.
Thanks for the patch!
Comment #6
dmakaridze CreditAttribution: dmakaridze commentedSubscribe
Comment #7
Volx CreditAttribution: Volx commentedYou missed one method (imagerotator_wijering_imagerotator_swftools_playlist()). I re-rolled the patch with that.
Comment #8
ticici CreditAttribution: ticici commentedthnx! I've just experienced the same warning and can confirm that its gone with installing 6.x-3.0-beta5.
Comment #9
3dloco CreditAttribution: 3dloco commentedPatch works great for me too. I also found another one (not in the current patch) with
&$method, &$vars
that throws an error but only sometimes....as stated in the comments above, removing the & for $method and $vars resolves the issue.
Comment #10
ñull CreditAttribution: ñull commentedSo if I understand right, with the patches applied it won't work with php 5.2 any more? By the looks of this you would need a php 5.2 and 5.3 branch then?
Comment #11
EugenMayer CreditAttribution: EugenMayer commentedthose patches aren't complete at all. $vars need to be called by ref, as it gets manipulated. as we forked swftools more then a year ago (due its not maintained anymore), i cannot provide you a proper patch, but more or less it looks like the one attached
Comment #12
somersoft CreditAttribution: somersoft commentedThere is a rerolled patch file.
Comment #13
somersoft CreditAttribution: somersoft commentedHere is the patch again, whith changes for the third parameter. :(