Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Several region templates have double dashes in their names. Camino and several other browsers seem to mis-interpret that as an end comment and cause serious layout damage.
I suggest changing all comments like this:
</section><!-- region--sidebar.tpl -->
to just a single dash like this:
</section><!-- region-sidebar.tpl -->
The user should still understand what section is ending and no breakage occurs in some (lesser used) browsers.
Comment | File | Size | Author |
---|---|---|---|
#2 | tpl-comment-1406704.patch | 1.45 KB | echoz |
Comments
Comment #1
JohnAlbinWhat? Really?
That's fubar. I can't replace "region--sidebar.tpl" with "region-sidebar.tpl" because the double-dash one is the filename. And the filename can't be changed.
Blargh. But the comment does need to be changed. Maybe just use the PHP version of the hook suggestion instead of the filename version? e.g. region__sidebar instead of region--sidebar.tpl. :-\
Who wants to write the patch?
Comment #2
echoz CreditAttribution: echoz commentedComment #3
jasondecamp CreditAttribution: jasondecamp commentedI ran into this problem with FF 3.6 which also can't handle the double dash within a comment.
Patch #2 worked for me.
Comment #4
JohnAlbinThanks, Rad and Elly! You're in the maintainers list now. http://drupal.org/node/88566/committers?sort=asc&order=User
Fixed.
Comment #5.0
(not verified) CreditAttribution: commentedforgot to wrap code in code tags