Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
All popup IFRAMEs are created with attribute scrolling="no"
. If the content inside the IFRAME is "bigger" than the actual modal view (in it's maximum size), user should be able to scroll the content. This works properly in Firefox for instance but Chrome ignores the overflow-y:scroll
CSS and disables scrolling of the IFRAME. There are possible CSS fixes available but none work nicely in all browsers.
Suggested fix is to set scrolling attribute to 'auto' as it's the default state and only explicitly set to 'no'.
Comment | File | Size | Author |
---|---|---|---|
#9 | without_patch.png | 264.39 KB | Devin Carlson |
#9 | with_patch.png | 266.63 KB | Devin Carlson |
#1 | media-scrolling-issue-1359524-2.patch | 580 bytes | peterpajchl |
Comments
Comment #1
peterpajchl CreditAttribution: peterpajchl commentedEnclosed patch sets IFRAME scrolling attribute defaults to 'auto'.
Comment #2
peterpajchl CreditAttribution: peterpajchl commentedSetting to "needs review"
Comment #3
dddave CreditAttribution: dddave commentedStill relevant?
Comment #4
dddave CreditAttribution: dddave commented#1: media-scrolling-issue-1359524-2.patch queued for re-testing.
Comment #5
dddave CreditAttribution: dddave commented@DaveReid or somebody who is in the know:
Do we still need this?
Comment #6
MPetrovic CreditAttribution: MPetrovic commentedYes, it's still relevant. I have 2 rows of items in my View and can't see the submit button without holding the middle mouse button down and dragging.
Comment #7
dddave CreditAttribution: dddave commentedYou can speed up the process if you could test the patch and post your findings here. ;)
Comment #8
Dave ReidI'm having a problem duplicating this condition in Chrome. If I increased the pager limit for the Media browser view to 50, the dialog still sizes it's height correctly so that I don't have to scroll.
Comment #9
Devin Carlson CreditAttribution: Devin Carlson commentedI've tested this with a number of themes and, depending on how they style things like exposed views filters, the buttons can be pushed off of the page and require a middle mouse button click to scroll to.
This patch guarantees that users will still be able to use the buttons regardless of which administrative theme they are using. It would also enable the extra "scrollbox" div on the library tab to be removed.
The patch applied cleanly with an offset. I've attached an image showing how the buttons can be hidden (using bartik as an example) and how the patch enables the iframe to be scrolled so the buttons can be reached.
I think that this is the best option, short of removing the ability to select a custom administration theme.
Comment #10
Devin Carlson CreditAttribution: Devin Carlson commentedMarked #1489690: media browser layout broken in Bartik as a duplicate.
Comment #11
Devin Carlson CreditAttribution: Devin Carlson commentedMarked #1490816: Media browser plus modal window height as a duplicate.
Comment #12
Devin Carlson CreditAttribution: Devin Carlson commentedMarked #1445994: risks of hidden overflow in modal popups as a duplicate.
Comment #13
drzraf CreditAttribution: drzraf commentedtested the patch, the above bug is not a duplicate
Comment #14
Dave ReidCommitted #1 to Git.
http://drupalcode.org/project/media.git/commit/5aaa570
http://drupalcode.org/project/media.git/commit/a581786
Comment #16
rfiertek CreditAttribution: rfiertek commentedHI,
Anyone have an idea how I could patch Drupal 6.x, where the proper js file is located?
Thanks,
Robert