Invoice: E_STRICT Warnings [#1463246]

Following E_STRICT Warnings appear on storm/invoices

Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 118 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 122 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 126 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 141 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 145 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 149 of storm/storminvoice/storminvoice.theme.inc).

Patch follows.

Comment	File	Size	Author
#1	storm_invoice_e_strict-1463246-1.patch	2.61 KB	kfritsche
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kfritsche

German

🇩🇪🇪🇺

CreditAttribution: kfritsche commented 1 March 2012 at 19:37

Status:

Active

» Needs review

File	Size
storm_invoice_e_strict-1463246-1.patch	2.61 KB

Here the Patch.

Comment #2

juliangb CreditAttribution: juliangb commented 2 March 2012 at 16:22

I'm a bit confused by why these weren't picked up by the testbots, as I thought that they were set to E_STRICT, and there is a test that requests this page.

That said, seems like a logical change, so from my read through it looks fine.

I haven't tested, but I'm guessing you have.