Because the openid.realm is generated as url('', array('absolute' => TRUE));
, the realm will different depending on which language page I'm on. On a default language page it will be http://example.com/ while on a Hungarian page, it will be http://example.com/hu if language path switching is turned on.
What this means is that the relying party will need to maintain multiple records for this site, since it will report different URLs based on which language page I was on.
My initial suggestion is to always use the default language to formulate the OpenID realm. This might however not be good for cases when domains play a part in language negotiation. Or better said, it is just a matter of perception. The same user on different domains showing the same site would probably equally be eligible to use his OpenID, so providing the default site root (without language affecting it) is the best as OpenID realm IMHO.
Comment | File | Size | Author |
---|---|---|---|
#17 | openid-language-d6_751578_17.patch | 912 bytes | sanduhrs |
#16 | openid-language-d6_751578_16.patch | 599 bytes | sanduhrs |
#11 | openid-language-d6_751578_10.patch | 904 bytes | xamanu |
#10 | openid-language-6.patch | 912 bytes | xamanu |
#1 | openid-language.patch | 1.12 KB | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsyIn fact, if you have the default language set, the language will be included even in this case in the URL. I think we can just skip using url() and use $base_url directly.
Comment #2
alexanderpas CreditAttribution: alexanderpas commentedI agree that using
$base_url
seems to be the best approach.(I wonder why the test status is "Ignored")
Comment #3
c960657 CreditAttribution: c960657 commentedWhy add a trailing slash?
Comment #4
Gábor HojtsyIt is how url() would have generated this before the patch (if without language URL mangling), so for backwards compatibility. Ie. if you already have an association with this URL on another provider, we should send the same URL going forward.
Comment #6
c960657 CreditAttribution: c960657 commentedSounds reasonable.
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #9
guillaumev CreditAttribution: guillaumev commentedHi,
Is this going to be fixed on Drupal 6 as well or is it just for Drupal 7 ?
Thank you.
Comment #10
xamanu CreditAttribution: xamanu commentedBackport for Drupal 6. Since this is a bug it would be nice to have it commited to Drupal 6.
Comment #11
xamanu CreditAttribution: xamanu commentedUploading patch that works fine with drush make
Comment #13
xamanu CreditAttribution: xamanu commentedNeeds review. Please.
Comment #14
sanduhrs#11: openid-language-d6_751578_10.patch queued for re-testing.
Comment #16
sanduhrsRerolling && RTBC.
Comment #17
sanduhrsSorry, lost the global underway.
Comment #18
Gábor HojtsyThanks, committed, pushed.