Test [#1136124] | Drupal.org

Comment	File	Size	Author
#17	fivestar.form-id-changes.patch	877 bytes	ericduran

#14	1136124-wrong-form_id-variable-14.patch	568 bytes	ericduran

#12	1136124-wrong-form_id-variable.patch	583 bytes	msonnabaum

#5	1136124-5.fivestar-tests.patch	3.48 KB	ksenzee

#1	0001-Adding-simpletest-basic-setup.patch	1.37 KB	ericduran

Comment #1

ericduran CreditAttribution: ericduran commented 30 June 2011 at 14:00

File	Size
0001-Adding-simpletest-basic-setup.patch	1.37 KB

Just started, nothing there yet just the skeleton.

Log in or register to post comments

Comment #2

ericduran CreditAttribution: ericduran commented 31 July 2011 at 17:37

Priority:

Normal

» Major

I have some local test written, need to update patch, still not ready and I'm waiting for the last critical issue to be fixed before we starting enforcing test.

Log in or register to post comments

Comment #3

ksenzee

she/her

Seattle area

CreditAttribution: ksenzee commented 7 August 2011 at 00:21

I also have some local tests written. They're probably a lot the same. Should I go ahead and upload a patch, or wait?

Log in or register to post comments

Comment #4

ericduran CreditAttribution: ericduran commented 7 August 2011 at 16:03

@ksenzee feel free to upload a patch, I'm waiting for #1212930: Convert the fivestar widget to use the D7 AJAX framework to get in, because that's going to break every test :)

Log in or register to post comments

Comment #5

ksenzee

she/her

Seattle area

CreditAttribution: ksenzee commented 9 August 2011 at 17:16

Status:

Active

» Needs review

File	Size
1136124-5.fivestar-tests.patch	3.48 KB

I just wrote a couple of tests that don't touch ajax yet for that very reason. Here they are. I suppose they might change when that issue gets in, but that issue needs tests anyway (which I am happy to write) so I don't think adding this to the codebase would hurt anything.

Log in or register to post comments

Comment #6

ericduran CreditAttribution: ericduran commented 2 September 2011 at 23:36

@ksenzee Thanks, I'm testing this now, This is great start., I need to send Acquia a gift basket ;)

Log in or register to post comments

Comment #7

ksenzee

she/her

Seattle area

CreditAttribution: ksenzee commented 2 September 2011 at 23:51

Heh. Other way around, I think. You've put up with our patches stacked up higher than a Jenga game. :)

Log in or register to post comments

Comment #8

ericduran CreditAttribution: ericduran commented 3 September 2011 at 00:16

Speaking of patches :) This is now fixed. I committed the patch above with changes required to meet the new instance settings.

http://drupalcode.org/project/fivestar.git/commit/5028ee587df103f47e72c5...

I'm leaving this active for now while I add the ajax text.

Log in or register to post comments

Comment #9

ericduran CreditAttribution: ericduran commented 3 September 2011 at 01:16

This one text that the proper ajax command is returned -- http://drupalcode.org/project/fivestar.git/commit/2bb3771

Still need to test the data in the ajax command.

As always more test are always welcome. I'm going to keep this issue open for a while, so we can keep adding test and attributing it to this issue.

Log in or register to post comments

Comment #10

ericduran CreditAttribution: ericduran commented 11 September 2011 at 19:07

Status:

Needs review

» Fixed

Closing this issue out. I added another set of test. I think for now this issue isn't needed.

Log in or register to post comments

Comment #11

25 September 2011 at 19:11

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #12

msonnabaum CreditAttribution: msonnabaum commented 15 March 2012 at 18:54

Status:

Closed (fixed)

» Needs review

File	Size
1136124-wrong-form_id-variable.patch	583 bytes

Opening this backup since 4f5a61d59b475a6a13f7eeeabac0236ee4cb74bb points here.

The comment introduced says:

// TODO: why does passing in NULL works, yet passing in the actual form-id doesn't work.

I think that's because the old version was doing:

drupal_process_form($form_state['form_id'], $form, $form_state);

instead of:

drupal_process_form($form_state['values']['form_id'], $form, $form_state);

I have no idea what's actually happening here, I just saw the php notice for $form_state['form_id'], which didnt exist, and would explain why it didnt work before.