Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The following patch allow users to choose a more specific way to render the breadcrumbs for a page display.
Also make breadcrumbs a plugin so other modules can provide new ones.
Comment | File | Size | Author |
---|---|---|---|
#16 | views-pluggable_breadcrumbs-1052312-16.patch | 14.84 KB | Andrew Answer |
|
Comments
Comment #1
dawehnerAdding a tag.
Comment #2
dagmarSome cleanup. IMO I don't think it need much more changes.
Comment #3
dagmarMissing translatable support.
Comment #4
dagmarAdded translatable support. Fixed some small issues with default values.
Custom breadcrumbs now don't merge with an existent breadcrumb, after all they are custom breadcrumbs.
Comment #5
Shadlington CreditAttribution: Shadlington commentedSubscribing
Comment #6
Shadlington CreditAttribution: Shadlington commentedI'm pleased to report that the patch works perfectly for me :)
Comment #7
Shadlington CreditAttribution: Shadlington commented-Deleted-
Comment #8
dagmarAfter read this http://drupal.org/node/646284#comment-4381712 I think the easier way to include pluggable breadcrumbs is using another module.
So I'm attaching two different patches. The first one is an improved version of patch #4, that includes the ability to modify the link title, and provides a better ui.
The second patch only includes the necessary structure to make breadcrumbs pluggable. Is something similar to what we did for pluggable Exposed Forms. Less lines of code, less to review.
Of course It would be nice to see the first patch in, but I don't have any problems to maintain another module to provide custom breadcrumbs, however I need the structure patch in to do that.
Let me know what do you think.
Comment #9
dagmarNew patch, now for 7.x-3.x
This code has a less intuitive UI than #8 but doesn't need a custom function to translate the strings.
Two plugins are provided, 'default' and custom that allow users to create breadcrumbs with three parts: title, link and description for the link:
Each part of the breadcrumb is defined in one line. Each line should have a title and optionally a path and a description for the link to generate, i.e:
Will produce a breadcrumb like this:
Home > My content > You are here
Comment #10
dawehnerThe patch is definitive great work.
Just in general i'm wondering whether this is in the scope of views. The module custom_breadcrumbs gives a very flexible way to configure breadcrumbs system wide. That's what people actually need, as they have breadcrumbs issues not only with views.
If that module even adds a display extender it would be capable of everything.
Comment #11
dagmarYes custom_breadcrumbs could do the job, as a custom module too.
However I'm thinking in three things at this moment.
1) Exportability (all the views stuff are into the view object)
2) Translations (allowing to translate all the part of the view using the new translation methods)
3) Access to arguments (I'm not sure if custom_breadcrumbs can do this at this moment)
Of course it is your decision, but something I have learn from views module is that allowing developers to create pluggings can make development of drupal sites much more powerful.
Comment #12
tim.plunkettTriggering the testbot.
Comment #13
markwk CreditAttribution: markwk commented@dagmar: nice work! I tested it on the latest dev work in 7x.-3.x and it works nicely. I agree with your reasoning. I think the best solution would be to get a simple structural patch accepted and move development to a separate module.
I'm not familiar with Views coding to access the code itself. Have any views maintainers accessed this?
Comment #14
tim.plunkettAssigning to @dawehner for feedback, I think #11 answers most of his questions.
Comment #15
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 7 year old patch in #9 does not apply to the latest views 7.x-3.x-dev and if still applicable needs a reroll.
Comment #16
Andrew Answer CreditAttribution: Andrew Answer as a volunteer commentedPatch rerolled.