Please ignore this thread. I just need to give testbot a hard time without cluttering up another issue with spam.

CommentFileSizeAuthor
#112 1463656-drupal-kernel.patch101.64 KBCrell
#109 1486960_109_drupal-kernel.patch100.64 KBcosmicdreams
#108 1463656-drupal-kernel.patch101.54 KBCrell
#105 1463656-drupal-kernel.patch104.55 KBCrell
#104 kernel-benchmark-head.patch284 byteseffulgentsia
#104 kernel-benchmark-staticloader.patch60.81 KBeffulgentsia
#104 kernel-benchmark-autoloader.patch60.84 KBeffulgentsia
#104 kernel-benchmark-full.patch104.1 KBeffulgentsia
#101 1486960-kernel-testbot-101.patch102.88 KBeffulgentsia
#100 1463656-drupal-kernel.patch105.68 KBCrell
#98 1463656-drupal-kernel-118-nohtaccess.patch105.26 KBeffulgentsia
#92 1463656-drupal-kernel.patch105.72 KBCrell
#90 1463656-drupal-kernel.patch105.83 KBCrell
#88 1463656-drupal-kernel-88.patch104.86 KBNiklas Fiekas
#86 1463656-drupal-kernel-86.patch104.88 KBNiklas Fiekas
#85 1463656-drupal-kernel-85.patch304.42 KBNiklas Fiekas
#83 1463656-drupal-kernel.patch99.19 KBCrell
#80 1486960_80_kernel.patch96.14 KBcosmicdreams
#78 1486960-kernel-testbot-78.patch95.46 KBeffulgentsia
#76 1486960-kernel-testbot-76.patch98.43 KBeffulgentsia
#74 1486960-kernel-testbot-74.patch96.28 KBeffulgentsia
#71 1486960-kernel-testbot-71.patch88.9 KBneclimdul
#67 1463656-drupal-kernel.patch88 KBCrell
#64 1496534_64_account_cmi.patch55.09 KBcosmicdreams
#62 1463656-drupal-kernel.patch91.58 KBCrell
#59 1463656-drupal-kernel.patch90.76 KBCrell
#55 1463656-drupal-kernel.patch95.3 KBCrell
#53 1463656-drupal-kernel+kernel-niklas.patch82.33 KBNiklas Fiekas
#51 1463656-drupal-kernel.patch74.39 KBCrell
#48 1463656-drupal-kernel.patch63.46 KBCrell
#46 1486960_45_kernel.patch147.84 KBcosmicdreams
#45 1486960_44_kernel.patch143.04 KBcosmicdreams
#42 1486960_42_kernel.patch522.36 KBcosmicdreams
#40 1486960_40_kernel.patch522.36 KBcosmicdreams
#38 1486960_38_kernel.patch1.15 MBcosmicdreams
#36 1463656_96_kernel.patch106.21 KBcosmicdreams
#33 1463656-drupal-kernel.patch59.99 KBCrell
#31 1463656-drupal-kernel.patch58.14 KBCrell
#29 1463656-drupal-kernel.patch169.58 KBCrell
#27 1463656-drupal-kernel.patch50.41 KBCrell
#25 1463656-drupal-kernel.patch46.76 KBCrell
#24 1463656-drupal-kernel.patch46.76 KBCrell
#21 1463656-drupal-kernel.patch40.98 KBCrell
#19 1463656-drupal-kernel-niklas.patch37.59 KBNiklas Fiekas
#17 1463656-drupal-kernel.patch33.93 KBCrell
#15 1463656-drupal-kernel.patch33.17 KBCrell
#13 1463656-drupal-kernel.patch31.96 KBCrell
#11 1463656-drupal-kernel.patch36.14 KBCrell
#9 1463656-drupal-kernel.patch35.36 KBCrell
#7 1486960-drupal-kernel_7.patch27.3 KBdeviantintegral
#5 1463656-drupal-kernel.patch27.3 KBCrell
#2 kernel-testbot.patch25.06 KBCrell
kernel-testbot.patch25.86 KBCrell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, kernel-testbot.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
25.06 KB

Status: Needs review » Needs work

The last submitted patch, kernel-testbot.patch, failed testing.

Crell’s picture

Status: Needs work » Closed (duplicate)
Crell’s picture

Status: Closed (duplicate) » Needs review
FileSize
27.3 KB

Trying again...

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

deviantintegral’s picture

Status: Needs work » Needs review
FileSize
27.3 KB
deviantintegral’s picture

Status: Needs review » Closed (duplicate)
Crell’s picture

Status: Closed (duplicate) » Needs review
FileSize
35.36 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
36.14 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
31.96 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
33.17 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
33.93 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Niklas Fiekas’s picture

Status: Needs work » Needs review
FileSize
37.59 KB

Testing the over-all effects of the changes.

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel-niklas.patch, failed testing.

Crell’s picture

FileSize
40.98 KB
Crell’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
46.76 KB
Crell’s picture

FileSize
46.76 KB

Maybe it jammed? :-(

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
50.41 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
169.58 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
58.14 KB

That was totally wrong.

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
59.99 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Issue tags: +wscci-hitlist

Tagging

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
106.21 KB

Status: Needs review » Needs work

The last submitted patch, 1463656_96_kernel.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
1.15 MB

OK, I see what I'm doing wrong, I'm not diffing this code with Drupal 8 HEAD. This patch is my first attempt to do this kind of a patch.

Status: Needs review » Needs work

The last submitted patch, 1486960_38_kernel.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
522.36 KB

That's what I get for trying to use format-patch. Here's a regular git diff

Status: Needs review » Needs work

The last submitted patch, 1486960_40_kernel.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
522.36 KB

Thanks pifr for finding that. sorry I missed that. Hopefully this one passes.

Status: Needs review » Needs work

The last submitted patch, 1486960_42_kernel.patch, failed testing.

cosmicdreams’s picture

this one should be smaller and effect fewer files. It's curious to see $_GET['q'] be replaced by current_path() since current_path() returns $_GET['q']. Is this a mechanism to replace how the current path is retrieved in the future? should I spread the change of $_GET['q'] to current_path() to every part of drupal?

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
143.04 KB

forgot patch

cosmicdreams’s picture

FileSize
147.84 KB

testing a hypothesis, the only difference between this patch and 45 is that I've change 12 instances of $_GET['q'] in menu.inc and common.inc to current_path().

Status: Needs review » Needs work

The last submitted patch, 1486960_45_kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
63.46 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
74.39 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Niklas Fiekas’s picture

Status: Needs work » Needs review
FileSize
82.33 KB

Testing how some changes perform.

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel+kernel-niklas.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
95.3 KB

Starting to get up there in size, but should be much better on the test front...

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

jthorson’s picture

Status: Needs work » Needs review

Once again, a testbot breaker ... or at least, a testbot plugger ...

ID 	                Message 	                                        Timestamp
3,648,263 	Requested by test client #664. 	20 min 44 sec ago
3,647,833 	Test reset by client request. 	        47 min 29 sec ago
3,647,733 	Requested by test client #699. 	1 hour 10 min ago
3,647,728 	Test reset by client request. 	        1 hour 10 min ago
3,647,683 	Requested by test client #699. 	1 hour 33 min ago
3,647,678 	Test reset by client request. 	        1 hour 33 min ago 

Hopefully these can shed some light on things ... This is just a select excerpt; the first one is the most common by about 5 times.

[Sun Apr 29 06:31:08 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\AccessDeniedHttpException: "" at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/EventSubscriber/AccessSubscriber.php line 39

[Sun Apr 29 06:31:14 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /aggregator/sources/1"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69

[Sun Apr 29 06:31:38 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /en/admin/config/regional/language"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69

[Sun Apr 29 06:31:38 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /en"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69

[Sun Apr 29 06:32:06 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "" at /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/common.inc line 717

[Sun Apr 29 06:33:14 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException: "No route found for "GET /pagedoesnotexist"" at /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/Symfony/Component/HttpKernel/EventListener/RouterListener.php line 69

[Sun Apr 29 06:47:05 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Exception: "Drupal is awesome" at /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/system/tests/modules/error_test/error_test.module line 56

[Sun Apr 29 06:47:05 2012] [error] [client 10.20.0.108] Uncaught PHP Exception Drupal\\Core\\Database\\DatabaseExceptionWrapper: "SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupaltestbotmysql.bananas_are_awesome' doesn't exist: SELECT * FROM bananas_are_awesome; Array\n(\n)\n" at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Connection.php line 533

[Sun Apr 29 06:47:07 2012] [error] [client 10.20.0.108] PHP Fatal error:  Exception thrown without a stack frame in Unknown on line 0
sun’s picture

As long as testbots aren't shielded against this attack ;)

the best way to avoid taking them down is to run at least one of the failing test cases locally.

---
That said, since the PSR-0/classloader changes in D8, my local PHP 5.3.6 frequently manages to freeze and take down my local Apache server on fatal or more severe exceptions. Perhaps something similar is happening on testbots? At least I've the impression something odd is going on in our codebase.

Crell’s picture

FileSize
90.76 KB

This is freshly merged from upstream to include the /index.php/ patch. Let's see what happens...

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

cosmicdreams’s picture

This appears to be the showstopper:

PHP Fatal error:  Exception thrown without a stack frame in Unknown on line 0
exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'variable_init' for key 'PRIMARY'' in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Statement.php:58
Stack trace:
#0 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Statement.php(58): PDOStatement->execute(Array)
#1 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Connection.php(506): Drupal\Core\Database\Statement->execute(Array, Array)
#2 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Database/Driver/mysql/Insert.php(34): Drupal\Core\Database\Connection->query('INSERT INTO {se...', Array, Array)
#3 /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Lock/DatabaseLockBackend.php(50): Drupal\Core\Database\Driver\mysql\Insert->execute()
#4 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/lock.inc(104): Drupal\Core\Lock\DatabaseLockBackend->acquire('variable_init', 1)
#5 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/bootstrap.inc(834): lock_acquire('variable_init', 1)
#6 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/drupal_web_test_case.php(1527): variable_initialize()
#7 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/drupal_web_test_case.php(1582): DrupalWebTestCase->refreshVariables()
#8 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/drupal_web_test_case.php(529): DrupalWebTestCase->tearDown()
#9 /var/lib/drupaltestbot/sites/default/files/checkout/core/scripts/run-tests.sh(369): DrupalTestCase->run()
#10 /var/lib/drupaltestbot/sites/default/files/checkout/core/scripts/run-tests.sh(22): simpletest_script_run_one_test('1', 'ContactSitewide...')
#11 {main}
Crell’s picture

Status: Needs work » Needs review
FileSize
91.58 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
55.09 KB

Searched through the code and found 5 or 6 instances where the frontpage settings were handled by variable_get, variable_set.
Fixed those and added some more debugging information. (which I will take out if this goes green)

cosmicdreams’s picture

woops wrong issue, sorry

Status: Needs review » Needs work

The last submitted patch, 1496534_64_account_cmi.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
88 KB

Status: Needs review » Needs work
Issue tags: -wscci-hitlist

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review

#67: 1463656-drupal-kernel.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +wscci-hitlist

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

neclimdul’s picture

aspilicious’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1486960-kernel-testbot-71.patch, failed testing.

effulgentsia’s picture

Status: Needs work » Needs review
FileSize
96.28 KB

This is #71 plus language negotiation fixes. Depending on test results, I'll commit the interdiff to a suitable branch.

cosmicdreams’s picture

#74: 1486960-kernel-testbot-74.patch queued for re-testing.

effulgentsia’s picture

#74 changes some bootstrap logic that affects all non-index.php scripts, like the bot runner, which is why it ran 0 tests. This adds a temporary _drupal_bootstrap_legacy() function to work around that.

Status: Needs review » Needs work

The last submitted patch, 1486960-kernel-testbot-76.patch, failed testing.

effulgentsia’s picture

Status: Needs work » Needs review
FileSize
95.46 KB

Sweet. That's a 90% failure reduction and 70% exception reduction. This should be the same from a test standpoint, but with a cleaner implementation.

Status: Needs review » Needs work

The last submitted patch, 1486960-kernel-testbot-78.patch, failed testing.

cosmicdreams’s picture

FileSize
96.14 KB

tiny change, a typo may have made one of the tests to fail.

cosmicdreams’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1486960_80_kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
99.19 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Niklas Fiekas’s picture

Status: Needs work » Needs review
FileSize
304.42 KB
Niklas Fiekas’s picture

Status: Needs work » Needs review
FileSize
104.88 KB

Ugg ... that should have been ..., not .. -- poor testbot :/ Wrong, too. Merge it and then diff next time.

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel-86.patch, failed testing.

Niklas Fiekas’s picture

FileSize
104.86 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel-88.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
105.83 KB

Status: Needs review » Needs work

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
105.72 KB
aspilicious’s picture

YEAY!!! GREEN!!!

But I noticed something...
Tests are slowed down by 10! minutes with this patch.

Seriously? Why?

pounard’s picture

Congrats!

cosmicdreams’s picture

OMG Green!

Reviewing...

andypost’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/tests/xmlrpc.test
@@ -99,7 +103,8 @@ class XMLRPCValidator1IncTestCase extends WebTestBase {
-    $xml_url = url(NULL, array('absolute' => TRUE)) . 'core/xmlrpc.php';
+    global $base_url;
+    $xml_url = $base_url . '/core/xmlrpc.php';

Is this a hack? Suppose better to add another array argument to url()

Crell’s picture

Status: Needs work » Needs review

Please don't post code reviews here. Let's keep those in the main thread. This issue is just for playing testbot pingpong. :-)

effulgentsia’s picture

This is same as #1463656-118: Add a Drupal kernel; leverage HttpFoundation and HttpKernel but without the .htaccess change. I'm curious if that change is required for tests to pass.

Crell’s picture

effulgentsia: Please remember to use the sandbox, since that's what we're merging from. Straight up patches are just duplicated work. :-(

Crell’s picture

FileSize
105.68 KB
effulgentsia’s picture

Same patch as in #1463656-125: Add a Drupal kernel; leverage HttpFoundation and HttpKernel, minus xmlrpc.test changes. If this passes, I will open a separate core issue for that, and a wscci sandbox issue to remove it from the kernel work.

Niklas Fiekas’s picture

@effulgentsia: Mhh ... looks like this has been solved (somehow) in the mean-time. Ensured it passes with clean URLs as well. I looked at the history and made sure it indeed failed at some point. Didn't bisect it, yet. But as long as it passes that's awesome. Do we even need a follow-up?

effulgentsia’s picture

Do we even need a follow-up?

Yes. See #1593674: Remove unrelated change to xmlrpc.test for details.

effulgentsia’s picture

Crell’s picture

FileSize
104.55 KB
aspilicious’s picture

Issue tags: -wscci-hitlist

#105: 1463656-drupal-kernel.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +wscci-hitlist

The last submitted patch, 1463656-drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
101.54 KB

Hopefully the last one...

cosmicdreams’s picture

An attempt to reroll after all the PSR-0 tests were committed

aspilicious’s picture

You're missing the node test stuff

   function testNodeFeedExtraChannelElements() {
-    ob_start();
-    node_feed(array(), array('copyright' => 'Drupal is a registered trademark of Dries Buytaert.'));
-    $output = ob_get_clean();
-
-    $this->assertTrue(strpos($output, '<copyright>Drupal is a registered trademark of Dries Buytaert.</copyright>') !== FALSE);
+    $response = node_feed(array(), array('copyright' => 'Drupal is a registered trademark of Dries Buytaert.'));
+    $this->assertTrue(strpos($response->getContent(), '<copyright>Drupal is a registered trademark of Dries Buytaert.</copyright>') !== FALSE);

Status: Needs review » Needs work

The last submitted patch, 1486960_109_drupal-kernel.patch, failed testing.

Crell’s picture

Status: Needs work » Needs review
FileSize
101.64 KB

Hopefully for the last time...

aspilicious’s picture

A random doc review so I remember all these issues I found for followups.

+++ b/core/includes/bootstrap.incundefined
@@ -4,6 +4,7 @@ use Drupal\Core\Database\Database;
 use Symfony\Component\ClassLoader\ApcUniversalClassLoader;
 use Drupal\Core\DependencyInjection\ContainerBuilder;
+use Symfony\Component\HttpFoundation\Request;

I would group symfony stuff but thats just me

+++ b/core/includes/file.incundefined
@@ -2517,7 +2509,8 @@ function file_directory_temp() {
+ *   \Symfony\Component\HttpFoundation\StreamedResponse.

Do we need the first backslasg?

+++ b/core/lib/Drupal/Core/ContentNegotiation.phpundefined
@@ -0,0 +1,54 @@
+   * @return

probabaly "@return string"

+++ b/core/lib/Drupal/Core/EventSubscriber/RouterListener.phpundefined
@@ -0,0 +1,96 @@
+   * {@inheritdoc}

I still don't like this...

+++ b/core/lib/Drupal/Core/EventSubscriber/ViewSubscriber.phpundefined
@@ -0,0 +1,128 @@
+class ViewSubscriber implements EventSubscriberInterface {

Has some undocumented functions, but is probably going to be rewritten...

+++ b/core/lib/Drupal/Core/ExceptionController.phpundefined
@@ -0,0 +1,406 @@
+class ExceptionController {

This controller has a lot of functions with missing @return documentation.

+++ b/core/lib/Drupal/Core/LegacyUrlMatcher.phpundefined
@@ -0,0 +1,164 @@
+   * @return Symfony\Component\HttpFoundation\Request $request

Request should be removed

+++ b/core/lib/Drupal/Core/LegacyUrlMatcher.phpundefined
@@ -0,0 +1,164 @@
+   * {@inheritDoc}
+   *
+   * @api

We should rewrite this in drupal api docs

+++ b/core/modules/overlay/overlay.moduleundefined
@@ -299,25 +301,48 @@ function overlay_page_alter(&$page) {
+ * Access callback; determines access to dismiss the overlay accessibility message.

Bigger than 80 chars?

26 days to next Drupal core point release.

pounard’s picture

I would group symfony stuff but thats just me

Agree.

Crell’s picture

Status: Needs review » Fixed

The kernel patch is now in(!), so we can close this issue, too.

aspilicious, can you open a new kernel-followup tagged issue with those tweaks?

GO TEAM!

Automatically closed -- issue fixed for 2 weeks with no activity.