Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1518116: [meta] Make Core pass Coder Review
Comment | File | Size | Author |
---|---|---|---|
#2 | 1533448.patch | 2.28 KB | lotyrin |
Comments
Comment #1
lotyrin CreditAttribution: lotyrin commentedComment #2
lotyrin CreditAttribution: lotyrin commentedInitial start.
Remaining output from coder:
Not sure what to do about the complaint about global names. I'm guessing that doesn't apply to core global space?
All of the string filtering still needs checked out. I imagine most if not all of them are false positives, but this issue is a good time to quadruple check.
Comment #3
lotyrin CreditAttribution: lotyrin commentedComment #4
lotyrin CreditAttribution: lotyrin commentedComment #5
tstoecklerThey are all fine. The only ones I would find debatable are:
Both of those cases use a !url placeholder for inserting a URL into t(). I think we usually use @url for that, so that !foo means we specifically want to allow HTML/unfiltered text, but that is only an asthetical question, as the URLs that are generated contain no unsafe output anyway. Don't know if we want to change that.
Comment #6
NROTC_Webmaster CreditAttribution: NROTC_Webmaster commentedAs a note #1326666: Clean up API docs for user module is still open and this should not contain any docblock changes until that is fixed.
Comment #7
lotyrin CreditAttribution: lotyrin commentedComment #8
lotyrin CreditAttribution: lotyrin commentedUnassigning because I'm not sure I'll have time for these issues and I want to make sure people know they can jump in without stepping on my toes.
Comment #9
Lars Toomre CreditAttribution: Lars Toomre commentedAs part of #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing*, I created a sub-issue #1800174: Add missing type hinting to User module docblocks to address the addition of missing type hinting to the User module. A first patch is posted there addressing about a dozen function docblocks. Reviews are welcome.
Comment #10
TravisCarden CreditAttribution: TravisCarden commentedPostponing till feature freeze. If you want to help in the meantime, please work on the blockers on the meta issue. Thanks!
Comment #11
TravisCarden CreditAttribution: TravisCarden commentedComment #12
george.d.peterson CreditAttribution: george.d.peterson commentedWorking on this in Austin
Comment #13
valthebaldWe are going to work on this issue during DCWroclaw 2014
Comment #16
TravisCarden CreditAttribution: TravisCarden commentedChanneling @xjm: Thanks for all the work here so far. See #1518116-86: [meta] Make Core pass Coder Review. This issue is postponed until the meta issue is either closed or reopened.
Comment #17
valthebaldComment #18
tatarbjClosing in favor of #2571965: [meta] Fix PHP coding standards in core. In this issue the coding standards will be fixed on a sniff-per-sniff basis rather than a module-per-module basis.