Make statistics module pass Coder Review

Postponed because of #1313510: Clean up API docs for statistics module

I'm taking this on.

Patch attached.

Coder reports no problems.

Code Sniffer reports several errors, but I consider all of those to be false positives/invalid:

FILE: .../modules/statistics/lib/Drupal/statistics/Tests/StatisticsAdminTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 185 | ERROR | Using the e flag in preg_match is a possible security risk. For
     |       | details see http://drupal.org/node/750148
--------------------------------------------------------------------------------

This seems to be an error in Drupal Code Sniffer.
See http://drupal.org/node/1779020

FILE: .../drupal8.local/public_html/core/modules/statistics/statistics.admin.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 318 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
--------------------------------------------------------------------------------

In my opinion, changing this would not do anything for readability. It would actually harm it.

FILE: ...dev/drupal8.local/public_html/core/modules/statistics/statistics.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  32 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
 327 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
--------------------------------------------------------------------------------

Line 32: All the output in the top is difficult to make readable, but I think it's alright the way it is.
Line 327: Same as previous file.

Postponing till feature freeze. If you want to help in the meantime, please work on the blockers on the meta issue. Thanks!

I have created a patch. Please review.

I have updated this patch as per https://drupal.org/comment/8601579#comment-8601579.

I'm reviewing the latest state of the core according to this issue now.

*deleted because duplication*

There isn't any state of the coder module right now, which makes it possible to review the code with coder. See https://www.drupal.org/node/2182043#comment-9208083. Have you reviewed the statistics module anyhow by command line?

Thanks for all the work here so far. See #1518116-86: [meta] Make Core pass Coder Review. This issue is postponed until the meta issue is either closed or reopened.

Closing in favor of #2571965: [meta] Fix PHP coding standards in core. In this issue the coding standards will be fixed on a sniff-per-sniff basis rather than a module-per-module basis.