Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1518116: [meta] Make Core pass Coder Review
- Yellow warning from Drupal 8 branch test code review (one normal reported, not enumerated)
- No errors or warnings reported using Coder 8
Minor: Drupal Coding Standards, Drupal Commenting Standards, Drupal SQL Standards, Drupal Security Checks, Internationalization
- No errors or warnings reported using Drupal Code Sniffer
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme
Comments
Comment #1
FluxSauce CreditAttribution: FluxSauce commentedComment #2
FluxSauce CreditAttribution: FluxSauce commentedCompleted.
Comment #3
FluxSauce CreditAttribution: FluxSauce commentedComment #4
TravisCarden CreditAttribution: TravisCarden commentedPer the instructions in the meta issue, @FluxSauce, everything you have in comment #2 should be moved to the issue summary, and you don't need to document what you fixed—only reported errors that you didn't fix. See an example at #1512434: Make Aggregator module pass Coder Review.
Comment #5
FluxSauce CreditAttribution: FluxSauce commentedSorry about that @TravisCarden, I'll reconcile shortly. Thanks for the feedback.
Comment #6
FluxSauce CreditAttribution: FluxSauce commentedSummarized.
Comment #6.0
FluxSauce CreditAttribution: FluxSauce commentedSummarizing work done
Comment #6.1
FluxSauce CreditAttribution: FluxSauce commentedBum HTML
Comment #7
NROTC_Webmaster CreditAttribution: NROTC_Webmaster commentedA couple of things.
According, to http://drupal.org/node/811254 getInfo() should not be translated with t().
While it is still being debated #338403: Use {@inheritdoc} on all class methods (including tests) for now we are not adding docblocks to getInfo(), setUp(), and tearDown().
Refer to http://drupal.org/node/1354 for all documentation standards, and http://drupal.org/node/325974 for SimpleTest specific standards.
Comment #8
FluxSauce CreditAttribution: FluxSauce commented@NROTC_Webmaster thanks for the review, I've corrected the issues as described. I made the
getInfo()
translate error elsewhere as well; glad I know about it now.Comment #9
sunPatch no longer applies.
Comment #11
FluxSauce CreditAttribution: FluxSauce commentedNot updating until #1518116: [meta] Make Core pass Coder Review is no longer postponed.
Comment #12
tomogden CreditAttribution: tomogden commentedComment #13
tomogden CreditAttribution: tomogden commentedShould we postpone this then?
Comment #14
jhodgdonYes.
Comment #15
Lars Toomre CreditAttribution: Lars Toomre commentedWhen a patch for this issue is next re-rolled, we need to ensure that a blank line is added after the last method and closing brace of the class for test classes like LocaleConfigOverride.php.
Comment #16
FluxSauce CreditAttribution: FluxSauce commentedComment #16.0
FluxSauce CreditAttribution: FluxSauce commentedCleanup
Comment #17
TravisCarden CreditAttribution: TravisCarden commentedComment #18
visabhishek CreditAttribution: visabhishek commentedComment #19
visabhishek CreditAttribution: visabhishek commentedI have Created a patch. Please review.
Comment #21
visabhishek CreditAttribution: visabhishek commentedPatch updated.
Comment #23
visabhishek CreditAttribution: visabhishek commentedComment #24
kadimi CreditAttribution: kadimi commented8: config_standardized-1533202-5900836.patch queued for re-testing.
Comment #26
mhaamann CreditAttribution: mhaamann commented2: config_standardized-1533202.patch queued for re-testing.
Comment #28
mhaamann CreditAttribution: mhaamann commented21: drupal-make_config_module_pass_coder_review-1533202-21.patch queued for re-testing.
Comment #30
xjmThanks for all the work here so far. See #1518116-86: [meta] Make Core pass Coder Review. This issue is postponed until the meta issue is either closed or reopened.
Comment #31
jhodgdonComment #32
pfrenssenClosing in favor of #2571965: [meta] Fix PHP coding standards in core. In this issue the coding standards will be fixed on a sniff-per-sniff basis rather than a module-per-module basis.