Update to latest Symfony 2.1 code [#1542710]

Chasing Symfony HEAD. :-) This is just a straight up update of the 6 components we have in core right now. In particular, there's 2 changes that make it important to do now:

1) Symfony recently moved all of their component unit tests into the components, to make it easier to spin off the components. (Fabien and Lukas has been discussing that at DrupalCon Denver.) So it now includes all of the unit tests for the components we're using. That's why the patch file is so huge.

2) It includes a couple of commits I've added to HttpFoundation/HttpKernel to help with the kernel patch. Specifically, it makes it possible (I believe) to bridge to our existing error handling system without rewriting the whole thing right now. For that reason I am marking this as major since it blocks the kernel.

There are no other changes outside of the vendor directory.

Let the Drupal commit message show that this corresponds to Symfony commit ID b0a6956bdc0e9ae39adf28b38037a9a905322916. (For later tracking purposes.)

Comment	File	Size	Author
#10	1542710-without-traits-and-services1-1-test.patch	1.05 MB	BTMash
#10
#6	1542710.patch	1.05 MB	BTMash
#6
	symfony-update.patch	1.05 MB	Crell

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

xjm

she/her

English

CreditAttribution: xjm commented 23 April 2012 at 02:29

Status:

Active

» Needs review

Comment #2

23 April 2012 at 02:30

Status:

Needs review

» Needs work

The last submitted patch, symfony-update.patch, failed testing.

Comment #3

RobLoach

he/him

CreditAttribution: RobLoach commented 23 April 2012 at 02:51

Yeeeeeeeeeah....

Comment #4

Crell CreditAttribution: Crell commented 23 April 2012 at 16:22

Oh for the love of... can we just switch to Composer already? Really? This issue is a complete waste of time we shouldn't be wasting.

Comment #5

neclimdul

He/Him

CreditAttribution: neclimdul commented 24 April 2012 at 15:57

Sounds like a problem of patch... composition. *glasses* YEEEEEEEAHHHH

Comment #6

BTMash CreditAttribution: BTMash commented 24 April 2012 at 16:05

Status:

Needs work

» Needs review

File	Size
1542710.patch	1.05 MB

Ok, this is a reroll - hopefully, this patch works (I did a checkout on commit b0a6956bdc0e9ae39adf28b38037a9a905322916 from symfony on github and did a staged binary diff since that seemed to be what was causing part of the issue).

Comment #7

24 April 2012 at 16:07

Status:

Needs review

» Needs work

The last submitted patch, 1542710.patch, failed testing.

Comment #8

BTMash CreditAttribution: BTMash commented 24 April 2012 at 16:33

Hmm, I delved a bit into what errors woudl pop up and there are 2:

PHP Parse error:  parse error in ./ClassLoader/Tests/Fixtures/php5.4/traits.php on line 3
Errors parsing ./ClassLoader/Tests/Fixtures/php5.4/traits.php
PHP Fatal error:  Cannot declare class Container because the name is already in use in ./DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
Errors parsing ./DependencyInjection/Tests/Fixtures/php/services1-1.php

The first is based on there being a php 5.4 test in there on traits. If we're on 5.3, that is going to fail (makes sense).

The second one is because the file declares the Container class even though Container is declared before it (use Symfony\Component\DependencyInjection\Container; on line 4 of the file)

Comment #9

BTMash CreditAttribution: BTMash commented 24 April 2012 at 17:49

It took me a while to try and install php5.4 but after installing it, the testbot would likely still run into the DependencyInjection test as I ran into it:

PHP Fatal error:  Cannot declare class Container because the name is already in use in ./DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
Errors parsing ./DependencyInjection/Tests/Fixtures/php/services1-1.php

So, we have one error that we need to try and figure a way around (ignore paths containing php5.4? @sun mentioned that this sounds like a core php bug?) but the DependencyInjection error stems from Symfony since you cannot redeclare classes. From what I can see, the test class is autogenerated by the PhpDumper class.