Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When I configure a subscription block and check the option "Display previous issues" and leave the number set to "5", I don't see any issues displayed in the block. Am I missing something?
Comment | File | Size | Author |
---|---|---|---|
#14 | simplenews-1524530-14.patch | 842 bytes | corvus_ch |
#11 | simplenews-1524530-11.patch | 3.5 KB | corvus_ch |
#2 | simplenews-1524530-2.patch | 3.33 KB | corvus_ch |
Comments
Comment #1
BerdirComment #2
corvus_ch CreditAttribution: corvus_ch commentedSteps taken to reproduce this bug:
As a result, the sent newsletter was listed as recent issue. For me, it is not possible to reproduce the described behaviour. To verify this in code, I wrote some tests.
@bjlewis2: If you still can't get it running, pleas provide more Information about your environment. What steps did you follow in order to ending up with the behaviour you described?
Comment #3
corvus_ch CreditAttribution: corvus_ch commentedComment #4
corvus_ch CreditAttribution: corvus_ch commented#2: simplenews-1524530-2.patch queued for re-testing.
Comment #6
corvus_ch CreditAttribution: corvus_ch commentedComment #7
corvus_ch CreditAttribution: corvus_ch commented#2: simplenews-1524530-2.patch queued for re-testing.
Comment #8
bjlewis2 CreditAttribution: bjlewis2 commentedWell, I'll be... must have been a stupid mistake on my part. Maybe I had only sent a test message or something... I don't know, but it sure is working. Sorry for wasting your time! ;(
Comment #9
BerdirLet's keep this at needs review, the patch adds test coverage for this which never hurts to have :)
Comment #10
BerdirTrailing spaces here and at the bottom.
/ is not necessary here, you can use an empty string.
This does not verify that they are actually the two most recent issues, could also be any combination of them.
Instead, try to explicitly verify that $generated_names[1] and ..[2] are there and ...[0] is not.
Comment #11
corvus_ch CreditAttribution: corvus_ch commentedComment #12
BerdirLooks good, commited.
Comment #13
BerdirThis is currently causing test failures.
We need to ensure that the three newsletters are created with a correct created timestamp.
Comment #14
corvus_ch CreditAttribution: corvus_ch commentedComment #15
BerdirThanks, commited. Overlooked the missing space and had already pushed, so fixed that in a separate commit.