Text field mapper: support for FeedsElement object [#1551852]

Text field mapper doesn't support FeedsElement.
I mapped SimplePie's enclosure field with simple text field and after the import field is blank.
The reason of this behavior is that text field mapper just ignores all objects rather than to receive value from them.

feeds/mappers/field.inc

if (!is_array($v) && !is_object($v)) {
  $field['und'][$i]['value'] = $v;
}

Comment	File	Size	Author
#3	feeds_FeedsElement_object_mapped_to_text_field_1551852_3.patch	1.23 KB	Sergii
#3
#2	feeds_FeedsElement_object_mapped_to_text_field_1551852_2.patch	602 bytes	Sergii
#2
#1	feeds_FeedsElement_object_mapped_to_text_field_1551852_1.patch	570 bytes	Sergii
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Sergii CreditAttribution: Sergii commented 28 April 2012 at 10:54

Status:

Active

» Needs review

File	Size
feeds_FeedsElement_object_mapped_to_text_field_1551852_1.patch	570 bytes

Add patch.

Comment #2

Sergii CreditAttribution: Sergii commented 28 April 2012 at 11:21

File	Size
feeds_FeedsElement_object_mapped_to_text_field_1551852_2.patch	602 bytes

New patch from module's root folder.

Comment #3

Sergii CreditAttribution: Sergii commented 28 April 2012 at 12:47

File	Size
feeds_FeedsElement_object_mapped_to_text_field_1551852_3.patch	1.23 KB

The same behavior for the link field mapper.

Comment #4

Sergii CreditAttribution: Sergii commented 18 July 2012 at 10:55

Priority:

Normal

» Major

Comment #5

twistor CreditAttribution: twistor commented 10 August 2012 at 07:12

Status:

Needs review

» Needs work

+++ b/mappers/field.incundefined
@@ -110,6 +110,12 @@ function _field_feeds_set_target($source, $entity, $target, $value, $input_forma
+      $text = $v->getValue();
+      if (is_string($text) && !empty($text)) {
+        $v = $text;

Don't do the is_string() or !empty() check here. It could be any scalar and the subsequent !is_array() and !is_object() checks will do just fine.