Fields are displayed even if "Exclude from display" is checked

Something else is going on here, I cannot replicate this at all. Try again using the latest versions of both Date and Calendar. Also be sure you have the very latest version of Views. Finally be sure you clear your caches, including the Views cache (the Views cache clear is on the 'Tools' tab of Views.

Seeing a field you didn't expect to see is not a major bug that makes the code unusable. And I suspect this is actually a support question and not a bug at all because it is working fine for me.

I have the same problem: cannot exclude the date or any other field. Order does not matter. The label does not display properly.

The day page works fine. Month and week always display the date and do not display labels.

Calendar 7.x-3.2 Date 7.x-2.5 Views 7.x-3.3

only multi-day was a problem

The only place I see a problem is on the multiday rows, all other cells are rendered exactly as they should be. I fixed the problem on multiday rows in my commit to get Colorbox working.

You can't do a lot of advanced styling on the multiday rows, but all others defer completely to do whatever Views wants to do -- they will display exactly the same as if you displayed them in a table or list or any other type of display. I added a checkbox to allow you to choose which fields should be excluded on multiday rows so you can omit any that don't work right in the multiday format.

I just made this commit, so you'll need to have the latest dev code that contains it, which should be in the dev tarball tomorrow.

If there is a problem after that, I need steps to reproduce, because it's working fine for me.

Make sure you clear your caches! I just upgraded to 7.x-3.3 and all my fields that were excluded from display were showing. I tried a number of things to fix it, but nothing worked til I cleared ALL my caches.

I fixed this issue by changing line 540 in theme/theme.inc

unset($vars['rendered_fields'][$field->field]);

in this:

unset($vars['rendered_fields'][$id]);

Firstly I copied the entire calendar_preprocess_calendar_item function to my own template.php

I can confirm both the problem, and the fix as in #7.

Calendar 7.x-3.4
Views 7.x-3.7

I too am having the same problem. I can also confirm that #7 is fixing the problem for me.

Hello,

I too am having the same problem.
I can also confirm that #7 is fixing the problem for me.

I add a patch to do it properly...

I was experiencing the same issue, the fix in #7 and the provided patch in #10 appear to fix the issue for me.

Thanks all.

I can confirm this was an issue for us. We had multiday events with fields listed twice in the field list, but one instance was excluded. The hidden field was showing on the calendar.

We are using Colorbox to display the hidden field.

Patch in #10 and cache flush fixed the problem.

We are on:
Colorbox 7.x-2.9
Calendar 7.x-3.5
Date 7.x-2.9
Views 7.x-3.11

We found this issue on our own and solved it exactly as the patch in #10.

The reason why this problem seems to happen "intermittently" is it's dependent on having two fields with the same field name on the same view.

The way this can be replicated is add "nid" twice as a field on a calendar view. This is a common occurrence if needing to reference the content type on which the view is based, plus a referenced entity via relationships. For our use case, an additional step is enter the Style options settings (Format: Calendar | Settings), and select both "nid" checkboxes in "Fields to hide in Multi-day rows". Both nid's should be hidden from view, but one is displayed.

In the view, the fields will be stored as "nid" and "nid_1". The problem with using $field->field as the name to unset the rendered field is it's always going to be the actual name, which in this case is "nid". The value stored in $vars['rendered_fields'] references the Views field name ("nid_1") and not the actual field name ("nid").

Using $id, which references the name stored with the view, fixes this problem.

I found this issue on my own. I can also confirm that #7 is fixing the problem for me. I tried to apply a patch in #10, but got error. I made exactly the same change and created a new patch. Thus I am able to do it properly to solve my issue.

@lily.yan, the patch you created is identical to #10, other than your version doesn't include the "index" line. I don't see a reason why another patch is necessary.

Are you sure you are applying the patch to 7.x-3.x-dev? It cannot be applied to the release version of the module.

@ron_s,

Yes, I am sure that I am applying the patch in #10 to 7.x-3.x(aafe5ae), and I am getting errors (error: patch failed: theme/theme.inc:540 and error: theme/theme.inc: patch does not apply). I also compared the difference between #10 and #14.

#14 has 'index 82fb5fb..e12b350 100644' and #10 doesn't have.
#14 has '@@ -540,7 +540,7 @@ function template_preprocess_calendar_item(&$vars) {',
but #10 has '@@ -540,7 +540,7 @@'.

I applied the patch in #14 to 7.x-3.x(aafe5ae) successfully.

Thanks

I can confirm that the patch in #10 does not apply to the latest 7.x-3.x.

Steps to reproduce:

$  git clone --branch 7.x-3.x https://git.drupal.org/project/calendar.git
$ cd calendar
$ wget https://www.drupal.org/files/issues/calendar-fields_are_displayed_even_if_exclude_from_display_is_checked-1539376-10.patch
$ git apply -v calendar-fields_are_displayed_even_if_exclude_from_display_is_checked-1539376-10.patch

The result of the attempt to apply the patch:

Checking patch theme/theme.inc...
error: while searching for:
  else {?
    foreach ($vars['view']->field as $id => $field) {?
      if ($field->options['exclude'] || (!empty($item->is_multi_day) && in_array($id, $multiday_hidden))) {?
        unset($vars['rendered_fields'][$field->field]);?
      }?
    }?
  }?

error: patch failed: theme/theme.inc:540
error: theme/theme.inc: patch does not apply

Reroll of patch from #10 against latest 7.x-3.x dev is attached.

Just tested, and patch #10 still works against the latest 7.x-3.x-dev. But if re-rolling makes some difference for you... makes no difference to me.

@ron_s How are you applying the patch? I'm following the official instructions, as noted in my comment, and getting an error message, which is why I rerolled.

Of course, if we could just get this patch into the module all would be moot. :)

@kpaxman, there are multiple ways to patch. If you look at the "official instructions" (https://www.drupal.org/patch/apply), the method you chose is not the only option.

It works for me both from the command line, and applying the patch directly from the IDE:

$ patch -p1 < ../calendar-fields_are_displayed_even_if_exclude_from_display_is_checked-1539376-10.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file theme/theme.inc
Hunk #1 succeeded at 541 (offset 1 line)

@ron_s Ah, I was looking here - https://www.drupal.org/project/calendar/git-instructions - which only lists the method I used.

Committed, Thanks.