Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
allow adding a chat to a node via a node-reference field.
allow adding a chat to a node via a node-reference field.
Comments
Comment #1
markwk CreditAttribution: markwk commentedThanks for opening this branch for me to work on it.
Two quick clarifications:
1.) you want be able to reference a preexisting chat as opposed to attaching a chat as a field? It seems like there is a usability issue if you expect people to do two things as opposed to one. But I can also see a usecase where you might want the same chatroom on multiple nodes? Love to hear your thoughts up front.
2.) there is currently no integration with node.js on this branch?
PS -- How can I clone the entire project history? I'd like to be able to have a single repo with branches 6.x and 7.x but I can't seem to get git clone on d.o. to play nicely?
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commented1) i'm open to other ideas on exactly how we make it possible to add a chat as a field. the basic idea i'm starting with is to try to keep as much of the 6.x-2.x code relevant as possible.
2) No. but have a look at chatroom_nodejs from the 7.x-1.x branch:
http://drupalcode.org/project/chatroom.git/tree/refs/heads/7.x-1.x:/chat...
should give you some ideas.
re git - no idea, clones work for me. maybe try in #drupal-gitsupport ?
Comment #3
markwk CreditAttribution: markwk commentedThanks. I'll start exploring...
Yeah, I guess it's an intentional design thing with d.o. git since they think we (anonymous users) might use too much bandwidth. I cloned them all individually and can examine that way.
Just a heads up: I posted the 6.x-3.x branch to my github so I can create a 6.x-3.x-dev for experimental and such. I'll, of course, post back patches on the 6.x-3.x branch. A maintainer of a different project got angry at me for doing this without asking, not quite sure why... Github is just nice for me to work with friends on stuff sometimes.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedthanks for the heads up, i'm totally fine with using github.
maybe post the link here though, in case anyone else wants to follow along?
Comment #5
markwk CreditAttribution: markwk commentedI guess there were a a couple tweaks in the git setup with d.o. I found it all now.
Comment #6
markwk CreditAttribution: markwk commentedHere's the github: https://github.com/markwk/chatroom
Comment #7
danielm CreditAttribution: danielm commentedSubscribing Chat Room 6.x with Node.js
Comment #8
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedNow that nodejs is pretty stable in D6, will nodejs support for chatroom be back ported?
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedi have no plans to do this work, as i don't use or care about D6 much.
however, i'll review patches if people submit them to the 6.x-3.x branch, and i'm happy to appoint a co-maintainer to look after that branch if someone wants to step up.
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commented.