I think page-backgrounds.css was a premature optimization. I actually rarely see this file get very big on a real site. Even one extensively styled.

Also the faux columns article it references needs a responsive layout update. It doesn't work as-is for responsive layouts.

Let's nix the whole stylesheet.

CommentFileSizeAuthor
#7 zen-1539166-7.patch950 bytesstar-szr
#6 1539166-remove-page-backgrounds-reference.patch615 bytesjtwalters
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Active » Fixed

Fixed. http://drupalcode.org/project/zen.git/commitdiff/a064f28

MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented

Where is the new recommended location, pages.css?

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

yeah, that's where I would put them. :-)

credible58’s picture

credible58 CreditAttribution: credible58 commented

I downloaded Zen today and, as you've indicated above, the pages-background.css file has been removed, and the README.txt updated. However, the STARTERKIT.info.txt file still references it.

Best regards...Paul

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Fixed » Needs work

Doh!

jtwalters’s picture

jtwalters CreditAttribution: jtwalters commented
Status: Needs work » Needs review
FileSize
1539166-remove-page-backgrounds-reference.patch615 bytes

Is this all that's needed?

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
FileSize
zen-1539166-7.patch950 bytes

Here's a rerolled patch from the zen directory - also removes page-backgrounds.css from zen-internals/template.zen.inc.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs review » Fixed

Fixed! :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.