Currently when a user uses their one-time login link there is a watchdog message associated with uid 0 but with text that lets us know which uid/name used the link. This is fun for visual review but pretty annoying if you're, say, trying to audit which users are logging in with the one-time link vs. the normal form.
This teeny tiny patch moves the watchdog call a few lines to make it way more useful.
Comment | File | Size | Author |
---|---|---|---|
#11 | 1564996-11-one-time-login-watchdog.patch | 1.32 KB | dcam |
#7 | 1564996_one_time_watchdog_more_info.patch | 1.37 KB | greggles |
#1 | 1564996_one_time_watchdog_more_info-D6.patch | 1.32 KB | greggles |
#1 | 1564996_one_time_watchdog_more_info-D7.patch | 1.37 KB | greggles |
#1 | 1564996_one_time_watchdog_more_info-D8.patch | 1.39 KB | greggles |
Comments
Comment #1
gregglesAnd patches.
Comment #2
gregglesahem.
Comment #4
gregglesThe file that matters passes tests.
Comment #5
chx CreditAttribution: chx commentedMakes sense and does not even break string freeze.
Comment #6
catchMakes sense. Committed/pushed to 8.x.
Comment #7
gregglesSame patch with a new name, hoping the d7 testbot will like this more.
Comment #8
dcam CreditAttribution: dcam commented#7: 1564996_one_time_watchdog_more_info.patch queued for re-testing.
Comment #9
gregglesSame RTBC as previous patch.
Comment #10
David_Rothstein CreditAttribution: David_Rothstein commentedMakes sense - seems like more of a bug fix than a feature request actually. Let's split the difference and call it a task :)
Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/bbf0134
This is marked as "needs backport to D6" so I'll move it back there, in case someone wants to work on it. I don't think non-security patches have been committed to Drupal 6 for a long time, though.
Comment #11
dcam CreditAttribution: dcam commentedBackported #7 to D6.
Comment #12
gregglesFWIW, I do consider this to be a security improvement.
Comment #13
gregglesSame RTBC as previous.
Comment #15
dcam CreditAttribution: dcam commentedThat failure is weird. D6 doesn't even have tests.