Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The OAuth module in Drupal should serve as a conduit to the OAuth PHP library; it should not contain the OAuth code itself when that is available elsewhere. We should separate this out using libraries and new adapter classes, if need be.
Comment | File | Size | Author |
---|---|---|---|
#7 | oauth-1433274-req_problem.patch | 2.35 KB | kotnik |
Comments
Comment #1
steinmb CreditAttribution: steinmb commentedSeen this discussion? #1148990: Add an oauth identity provider to core
Comment #2
juampynr CreditAttribution: juampynr commentedDone.
http://drupalcode.org/project/oauth.git/commitdiff/3c81a0c
Backporting to 6.x-3.x.
Comment #3
steinmb CreditAttribution: steinmb commentedjuampy, do you have time to sum up what in the 6.x branch that needs work?
best reg
Stein
Comment #4
juampynr CreditAttribution: juampynr commentedSure. Basically its about making the same changes as the above commit on the 6.x-3.x branch. I started yesterday but found a couple of issues when testing it.
Comment #5
juampynr CreditAttribution: juampynr commentedBackported to Drupal 6.
http://drupalcode.org/project/oauth.git/commitdiff/fe81c2e
Comment #6
voxpelli CreditAttribution: voxpelli commentedUm - the OAuth library was included in the module because it was patched to provide support for some things that hadn't yet been included in the upstream library and as far as I remember not everything has yet been that? Yet this module now points to the upstream library as the one to be included and thus breaks backwards compatibility with previous versions when it comes to eg. http://oauth.googlecode.com/svn/spec/ext/consumer_request/1.0/drafts/2/s... and likely also http://oauth.googlecode.com/svn/spec/ext/body_hash/1.0/oauth-bodyhash.html
Comment #7
kotnik CreditAttribution: kotnik commentedRegarding http://drupalcode.org/project/oauth.git/commitdiff/3c81a0c.
You can not do module_enable or depend on another module during the $phase=='install' in hook_requirements(). This is the phase during Drupal installation and it completely breaks it - and having OAuth where it should be is no way crucial to the installation of Drupal. This *must* go to $phase=='runtime'.
Attached a patch with the fix for this.
Comment #9
kotnik CreditAttribution: kotnik commentedPlease consider adding patch in #7 in addition to the one in #2, since the change in #2 alone prevents installation of Drupal if you use a profile with OAuth.
Comment #10
juampynr CreditAttribution: juampynr commentedGreat feedback folks. What I will do instead is to move the library we had inside the module to Github. That way, we can still patch it.
Done that, next step will be #1591692: Replace current OAuth library.
Comment #11
juampynr CreditAttribution: juampynr commentedGonna start with the following:
Further work regarding changing to another library or writing a new one will be discussed at #1591692: Replace current OAuth library
Comment #12
juampynr CreditAttribution: juampynr commentedReverted changes in 7.x-3.x: http://drupalcode.org/project/oauth.git/commitdiff/9f8ac3a
Branch 7.x-4.x is ready for #1591692: Replace current OAuth library
Backporting.
Comment #13
juampynr CreditAttribution: juampynr commentedReverted changes in 6.x-3.x: http://drupalcode.org/project/oauth.git/commitdiff/7af879a
Comment #14
juampynr CreditAttribution: juampynr commentedChanged README and hook_requirements at 7.x-4.x so it references our library, which has been moved to Github. This OAuth.php is the one we have in the module at previous versions.
http://drupalcode.org/project/oauth.git/commitdiff/ef716bf
Comment #15
juampynr CreditAttribution: juampynr commentedApplied kotnik's patch. Thanks!
http://drupalcode.org/project/oauth.git/commitdiff/4ee27bb
So this closes this issue. Here is a summary: