Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Noticed the user_relationships hook_menu comment was missing, so ran module through coder and then fixed some areas coder didn't pick up.
Comment | File | Size | Author |
---|---|---|---|
#3 | user_relationship-1607020-coding-standards_3.patch | 71.34 KB | hefox |
user_relationship-coding-standards.patch | 68.99 KB | hefox |
Comments
Comment #2
BerdirThanks!
The problem with fixing coding style is that it often conflicts with other patches but there aren't many big ones needs review currently. Let's fix a few additional things while we're at it (see below) and then I'll commit it.
Let's fix this as well while you're at it. Add a @todo stating that this only exists to define test dependencies.
While you're at it, can you fix the comments of *changed* (not everything, that would be too much) lines as well? This isn't reported by coder.module but comments should start with a space, then an uppercase character and end with a ".".
Haven't seen this before, interesting...
Same here, let's fix stuff that we touch.
"iff" => "if"
The correct thing to do here is actually to move the comment above and format properly.
Comment #3
hefox CreditAttribution: hefox commentedthe first patch was mostly automated via http://upgrade.boombatower.com/tools, then ran it through coder locally to fix what it couldn't fix, then fixed some additional items like the hook_menu.
Anyhow updated patch with above.
Comment #4
BerdirThanks, haven't done a second review so this might not be perfect but it's a huge step in the right direction. Commited.