Remove entity_label() in favor of EntityInterface::label()

Don't we need the wrapper function stuff for menu callbacks?

#4 sounds good to me

Will need a reroll I guess

Is there a reason for switching to entity_page_label. Whats wrong with entity_label. I don't think it should be renamed because it's depricated in most cases.

Is there a reason for switching to entity_page_label. Whats wrong with entity_label. I don't think it should be renamed because it's depricated in most cases.

It makes clear it's just there for menu-callbacks. If that needs goes away, entity_page_label() can be obviously removed as well. If we stay with entity_label() that's not so clear as it's supposed to be an API function, not a callback.

I wanted to rtbc but I still don't have a clue why the test additions in field module should be added...

Don't ment to rtbc yet...

Oh well it looks good and Berdir probably will answer my question soon ;)

yep, having the controller requiring the revision table if revisions are used makes sense.

+++ b/core/modules/user/lib/Drupal/user/Tests/UserEntityCallbacksTest.php
@@ -25,19 +25,19 @@ class UserEntityCallbacksTest extends WebTestBase {
-    $this->anonymous = drupal_anonymous_user();
+    $this->anonymous = entity_create('user', (array)drupal_anonymous_user());

The cast misses a space. Fixed that and tried to improve the comments of entity_page_label() a bit. Please review.

I guess we should fix drupal_anonymous_user() to return an entity as well? But that can be done in a separate issue.

+++ b/core/modules/entity/entity.module
@@ -414,31 +415,19 @@ function entity_uri($entity_type, $entity) {
+ * be used as callback, e.g. for menu title callbacks.

I think it should be: "used as A callback"

Rerolled and fixed the docs for entity_page_label().

Fixed #20 and rerolled the patch.

Too late.. ;)

Found entity_label() reference in entity.api.php

Better docs: Entity::label() implements this logic. entity_page_label() not.

Good catch, improvements look great. Back to RTBC then!

In docs we use full paths, so please change the following. Will leave this rtbc for now.

+++ b/core/modules/entity/entity.api.phpundefined
@@ -50,7 +50,7 @@
+ *     entity label. See also the Entity::label() method, which implements this

Should be Drupal\entity\Entity::label()

+++ b/core/modules/entity/entity.moduleundefined
@@ -414,31 +415,19 @@ function entity_uri($entity_type, $entity) {
+ * This is a wrapper for EntityInterface::label(). This function should only

Drupal\entity\EntityInterface

+++ b/core/modules/entity/entity.moduleundefined
@@ -414,31 +415,19 @@ function entity_uri($entity_type, $entity) {
+ * @see EntityInterface::label()

Same

12 days to next Drupal core point release.

Um true. I don't like it very much as it makes the docs much more verbose, but that's a separate issue.

addressed #27.

Looks good.

Ok, I think this makes sense, including the re-naming of the "entity_page_label()" function, since otherwise that looks really tempting to call instead of $entity->label().

I had the same comment about jankiness of drupal_anonymous_user() that was in #17, but this was addressed in the issue as being not possible to clean up now.

Committed and pushed to 8.x. Thanks!

yes it does!

My mistake, thanks!

It's already mentioned that entity_label() is now deprecated in http://drupal.org/node/1400186. Once the entity_uri() patch is in as well, I think we can update this change notice to say they are gone. But as #35 points out there are more entity label related changes, so I think a separate change notice makes sense. (language, callbacks, ..) I'd prefer a single one that summarizes everything related to labels though. That way developers get not overloaded with change notices....

Related, I guess we should think about removing the label callback, but that's another issue.

Documented at http://drupal.org/node/1642962

Restoring original issue properties.

WOOHOO. Thanks for the help, amaia!

Thank you webchick for walking me through it :)
I hope to be able to contribute some more from now on.

Removing sprint tag.