Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
On UC checkout page by chose Card payment metod appears: What is CCV? help button, witch pops-up a window of detais without appropriate character encoding.
Please modify the certain line to insert: charset=utf-8,
? ubercart/payment/uc_credit
Index: ubercart/payment/uc_credit/uc_credit.theme.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/ubercart/payment/uc_credit/uc_credit.theme.inc,v
diff -u -p -r1.0 uc_credit.theme.inc
--- ubercart/payment/uc_credit/uc_credit.theme.inc 25 Apr 2012 19:23:58 -0000 1.0
+++ ubercart/payment/uc_credit/uc_credit.theme.inc 27 May 2012 12:00:00 -0000
@@ -15,2 +15,2 @@
- 'onclick' => "window.open(this.href, 'CVV_Info', 'toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=1,width=480,height=460'); return false;",
?>
+ 'onclick' => "window.open(this.href, 'CVV_Info', 'charset=utf-8, toolbar=0, scrollbars=1, location=0, statusbar=0, menubar=0, resizable=1, width=480, height=460'); return false;",
?>
Comment | File | Size | Author |
---|---|---|---|
#5 | 1602202-html5-cvv-popup.patch | 1.33 KB | longwave |
#1 | uc_credit.theme.inc.patch | 818 bytes | Benwick |
Comments
Comment #0.0
Benwick CreditAttribution: Benwick commentedformatting
Comment #0.1
Benwick CreditAttribution: Benwick commentedonly text formatting
Comment #0.2
Benwick CreditAttribution: Benwick commentedpatch like text formatting
Comment #1
Benwick CreditAttribution: Benwick commentedi'm composed this patch for it.
Comment #3
longwaveWhy is this needed? In Firefox the popup is already detected as UTF-8. I also can't find any reference that says window.open() accepts "charset" in the third parameter.
Comment #4
Benwick CreditAttribution: Benwick commentedI don't know exactly, perhaps it's an tpl issue, but with it works as i need.
Comment #5
longwaveCan you test this alternative patch? This adds a doctype and full HTML wrapper around the CVV popup, including the UTF-8 charset meta tag.
Comment #6
longwaveCommitted a slightly modified version of #5 that means the HTML on this popup finally validates.
http://drupalcode.org/project/ubercart.git/commit/bf6d332
Comment #7.0
(not verified) CreditAttribution: commentedpatchlike text formatting 2