Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Steps to reproduce:
Create two features, each with at least 2 variants of the same page.
Change one of the variants
Run drush fua -y
Run drush fl
Expectation: Nothing is overridden.
Reality: The features are marked as overridden.
Then, just to compound everything:
Run drush fra --force -y
Run drush fl
Pick one of the features that is STILL marked overridden
Run drush fd THAT_FEATURE
It will report that nothing is overridden.
Comment | File | Size | Author |
---|---|---|---|
#1 | features-1647894-1.patch | 1.13 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettWhen exporting page handlers, it assigns each pane a "new-*" ID.
The counter for that ID is statically cached, since only one is exported at a time.
However, when running features-list, it renders all at once, which never resets the counter.
In code:
Generated for comparison:
This resets that ID when appropriate.
Comment #2
tim.plunkettNote, the second example in #1 with the sequential ids is wrong. The patch makes the generated code match the default code.
Comment #3
mpotter CreditAttribution: mpotter commentedWow, nice catch Tim, that must have been "fun" to debug. Committed and pushed to 7926e6c.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedThis patch works like a charm in version 7x-1.0-rc3
Thanks!
Comment #5
mstrelan CreditAttribution: mstrelan commentedI think this is related #1277908: Introduce UUIDs onto panes & displays for better exportability & features compatibility
Comment #6
jweowu CreditAttribution: jweowu commentedAlso cross-referencing this with #1369246: Features incorrectly reporting panels as overridden. Pid counting changed. (which was one of the reasons for the UUID patch).
Comment #7
Steven Brown CreditAttribution: Steven Brown commented@mpotter, I'm a little confused. You've stated that the patch has been committed and that was June 20th. The currently release of Features was on July 25th. I still get the problem in D7.
Comment #8
Steven Brown CreditAttribution: Steven Brown commentedMy apologies it just dawned on me that I made this feature on one of my Aegir platforms that was made back in April and I'm installing it on my new platform which was made this week.
Very sorry for mucking up the Issue Queue. Thanks for the work!
Comment #10
apadernoI am closing this issue, as it's for a not supported project version.