Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
like http://drupal.org/project/geofield, leaflet could provide a make file for automatic configuration (download the leaflet javascript library).
see http://drupalcode.org/sandbox/dasjo/1408378.git/commit/refs/heads/7.x-1....
Comment | File | Size | Author |
---|---|---|---|
#4 | leaflet_1432614-5_follow_up_no_recursive_makefile.patch | 1.32 KB | adamdicarlo |
Comments
Comment #1
nottaken CreditAttribution: nottaken commentedcreate a leaflet.make with something like this..
; $Id$
api = 2
core = 7.x
projects[] = libraries
libraries[leaflet][download][type] = "get"
libraries[leaflet][download][url] = "https://github.com/CloudMade/Leaflet/tarball/master"
libraries[leaflet][directory_name] = "leaflet"
libraries[leaflet][destination] = "libraries"
Comment #2
levelos CreditAttribution: levelos commentedComment #4
adamdicarlo CreditAttribution: adamdicarlo commentedThe makefile should not end with .make because Drush Make automatically picks it up when building a site from a makefile, and I end up with "libraries" in my modules directory (*as well as* in modules/contrib), even though my makefile itself indicates libraries to go into "contrib". I think the standard approach now is to include a .make.example file (e.g., geofield).
Follow-up patch attached.
Comment #5
dasjoi would be interested if can you post a reference, that this is a "standard approach now".
otherwise we could also file an issue for drush make in order to have it behave correctly.
Comment #6
adamdicarlo CreditAttribution: adamdicarlo commentedI don't have any references; I noticed that geofield module does it this way to avoid the same problem, so it seemed like the way to go. Though you have a point about adding a --no-recursion option to drush make. That might be a better solution.
I'll ping jhedstrom (drush make maintainer) about this on Monday.
Comment #7
jhedstromUnfortunately, due to the way drush make currently handles recursive builds, there is no way for the end developer to override options or parameters specified in remote .make files. As such, moving these to foo.make.example has become a sort of informal standard, if only until make can handle overriding remote make files easier.
For a bit more background on this, see the rules issue about the same thing.
Comment #8
dasjothanks for the background info.
seems like the way to go for now
Comment #9
pvhee CreditAttribution: pvhee commentedSuggestion from #7 committed: http://drupalcode.org/project/leaflet.git/commit/33d829d