Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I use video_filter module with video filter plugin for ckeditor (standalone). Whenever I put a youtube video in my content (autoplay unchecked), the video always start in autoplay. Any idea why is that ?
Thanks in advance.
Comment | File | Size | Author |
---|---|---|---|
#8 | video_filter-autoplay-ckeditor-1430680-8.patch | 389 bytes | ordermind |
#7 | video_filter-autoplay-1430680-6.patch | 473 bytes | joel_osc |
Comments
Comment #1
b2f CreditAttribution: b2f commentedI fixed it by adding one line to plugin.js where the checkbox is checked :
Comment #2
blackdog CreditAttribution: blackdog commentedMaybe this is because the "Autoplay" setting is set to Yes?
Comment #3
b2f CreditAttribution: b2f commented1. Where is this Autoplay setting configuration if it's not the autoplay checkbox ?
Rest of of the comment was not relevant so I deleted it.
Comment #4
Rich_Weiss CreditAttribution: Rich_Weiss commentedWhen I add a video link, and check the "Autoplay" box in the Video Filter Dashboard, it adds the autoplay:1 switch to the video filter line. I manually edited it to autoplay:0 and the video does not autoplay, which is the desired result when the "Autoplay" box is unchecked. However, when the "Autoplay" box is unchecked, the autoplay switch is not added, and subsequently the plugin.js script sets it to on.
Rather than relying on the plugin.js script, or other similar scripts, to decide how to set the autoplay when no switch is sent to it, or patching the scripts manually, perhaps it would be better if that switch was automatically included and set to 0 by default, and alternatively set to 1 when the Autoplay box is checked.
For now I'm manually adding autoplay:0 to all of my links so that I know they will default to off.
Comment #5
polskikrol CreditAttribution: polskikrol commentedHave the same problem. When I do not check 'autoplay' I get the following error:
Autoplay field is required.
My only option is to enable autoplay. However, I do not want autoplay enabled.
Comment #6
joel_osc CreditAttribution: joel_osc commentedSeeing same issue, fixed as per Zen Master by adding a couple of lines around line 35 of editors/tinymce/video_filter.js to:
Seems to work well now.
Comment #7
joel_osc CreditAttribution: joel_osc commentedHere is a quick patch if interested.
Comment #8
ordermind CreditAttribution: ordermind commentedHere's a patch for ckeditor.
Comment #9
kalman.hosszu CreditAttribution: kalman.hosszu commentedI tested it with tinymce, and it works well.
Thanks
Comment #10
jenlamptonThe patch in #7 also worked for me. Thanks guys!
Comment #11
trillex CreditAttribution: trillex commentedNevermind, sorry.
Comment #12
estoyausente#7 work fine in my site. Plz commit. :)
Comment #13
DamienMcKennaThis should be added to the next release.
Comment #14
DamienMcKennaComment #15
grom358 CreditAttribution: grom358 commentedTested in Chrome and does not work, due to window.showModalDialog is undefined. So it doesn't use the version of popup using the insert function. Need to also patch video_filterDialog
Comment #16
grom358 CreditAttribution: grom358 commentedSorry my bad. I notice my issue is due to also using the patch from https://www.drupal.org/node/2335169
So there is cross over between these issues.
Comment #17
grom358 CreditAttribution: grom358 commentedI have created a patch for modal that includes this fix and applies the same fix to the modal dialog. So if you want both patches see https://www.drupal.org/node/2335169#comment-9727685
Comment #18
Shisha Điện tử CreditAttribution: Shisha Điện tử commentedI don't wanna use patch. Can i use code only?
Comment #19
blackdog CreditAttribution: blackdog commentedSo this is fixed by the commit in https://www.drupal.org/node/2335169?
Comment #20
DamienMcKennaYes, this was fixed by #2335169: Reliance on showModalDialog breaks CKEditor plugin in Chrome, though the code looks a little silly.
Comment #21
DamienMcKenna