Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If there were no calls to drupal_add_js()
with non-empty data, the settings array is not set and the following notices and warning appear on the line #215 of views_plugin_cache.inc
(in views_plugin_cache->gather_headers()
):
- Undefined index: settings
- Undefined index: settings
- array_diff_assoc(): Argument #1 is not an array
Comment | File | Size | Author |
---|---|---|---|
#3 | views-1636024-3.patch | 1.95 KB | Dmitriy.trt |
#1 | views-1636024-1.patch | 1.18 KB | Dmitriy.trt |
Comments
Comment #1
Dmitriy.trt CreditAttribution: Dmitriy.trt commentedFix for this problem.
Comment #2
dawehnerThis looks pretty fine, not sure whether this might be worth to write a test for that.
Comment #3
Dmitriy.trt CreditAttribution: Dmitriy.trt commentedFound a workaround in cache tests to suppress warnings described above. New patch removes this workaround.
I think the test for this problem is not necessary. The test from which I've removed the workaround will fail anyway because of warnings if the problem appear again in the future. But I could write a separate test if you think we really need it here.
Comment #4
dawehnerNice! This looks fine, lets get it in.
Comment #5
Dmitriy.trt CreditAttribution: Dmitriy.trt commentedThanks!