Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The og_moderation module generates some additional permissions missing from the standard OG list. Given the current column definition of varchar(64), if the name of the content type is too long, while legal, the generated permission name will be too long.
Updating to varchar(128) seems like a better size to me. I will attach a patch once the thread gets started.
Comments
Comment #1
pgillis CreditAttribution: pgillis commentedComment #2
amitaibuI see core is also using 128. Can you please also add an upgrade_path.
Comment #3
pgillis CreditAttribution: pgillis commentedI've added upgrade_path to patch.
Comment #4
amitaibuUpdate should be in the form of og_update_700X() -- otherwise it won't work for people that already have 1.x or 2.x-alpha installed.
Comment #5
pgillis CreditAttribution: pgillis commentedI have installed an upgrade path. I used og_update_720X() instead because it didn't seem to run after 7.x-1.x was installed with 700 prefix. That said, is it ok that it runs this step even on a fresh install?
Edit: You can ignore this patch, I have submitted a cleaned up one in the next post.
Comment #6
pgillis CreditAttribution: pgillis commentedcleaned up some whitespace and added the newline that was missing from the end of original file.
Comment #7
pgillis CreditAttribution: pgillis commentedI'm having a bad day. I didn't notice those tabs getting inserted in there:(
Comment #8
amitaibuThis isn't needed.
We can't use 7000_info() -- as that's needed from 6.x to 7.x migration.
Comment #9
pgillis CreditAttribution: pgillis commentedOk, I think I finally understand how all these pieces fit together! Thank you for your patience
Comment #10
amitaibu> Thank you for your patience
Thank you for working on it :)
I have actually just removed this function because it's not needed. The correct way of getting the schema of the field, is manually define it:
Comment #11
pgillis CreditAttribution: pgillis commentedOk, I think I finally have it.
Comment #12
pgillis CreditAttribution: pgillis commentedComment #13
amitaibuthat's not needed, I've removed it and committed. thanks.
Comment #15
rlmumfordAs this is a bug, can we have this back-ported to 7.x-1.x?
Comment #16
rlmumfordComment #17
amitaibuCommitted, thanks.