[D6] Destroys existing instance when trying to replace it [#1663462]

Ran in to an issue where I was getting a JavaScript error stating the CKEditor instance already exists. This patch fixes the issue by destroying the instance if it already exists before trying to replace it.

Comment	File	Size	Author
#4	0001-1663462-by-dczepierga-Destroy-existing-instance-when.patch	1.21 KB	dczepierga
#4
	ckeditor-instance-already-exists.diff	253 bytes	greenSkin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mkesicki CreditAttribution: mkesicki commented 28 June 2012 at 06:23

Thank you for your patch. We will check this as soon as possible.
Please be patient.

Comment #2

dczepierga CreditAttribution: dczepierga commented 29 June 2012 at 07:25

Status:

Needs review

» Postponed (maintainer needs more info)

@greenSkin, could u write how to reproduce this?

Greetings

Comment #3

greenSkin CreditAttribution: greenSkin commented 1 July 2012 at 16:15

Status:

Postponed (maintainer needs more info)

» Needs review

The steps to reproduce can be a little tricky as it is AJAX related. Basically you load the page either with the textarea loaded on page load or via an AJAX callback; no problems, everything works fine. The issue comes when you remove that textarea and replace it with the same one. The CKEditor doesn't know it was replaced so when the behaviors tries to initialize the new editor it errors that it already exists.

The simplest of fix is what the patch attempts, to destroy any pre-existing editor before trying to initialize it again.

Hope that helps. :)

Comment #4

dczepierga CreditAttribution: dczepierga commented 2 July 2012 at 06:35

File	Size
0001-1663462-by-dczepierga-Destroy-existing-instance-when.patch	1.21 KB

@greenSkin, could u try review my patch? It will be better to destroy CKEditor by textarea_id - if it will be more CKEditor instances in one page u will destroy last one replaced - not selected in that moment...

Greetings

Comment #5

greenSkin CreditAttribution: greenSkin commented 2 July 2012 at 18:12

Status:

Needs review

» Reviewed & tested by the community

@dczepierga: Yes, that works wonderfully. Thank you!

Comment #6

dczepierga CreditAttribution: dczepierga commented 3 July 2012 at 07:13

Title:	Destroy existing instance when trying to replace it	» [D6] Destroy existing instance when trying to replace it
Status:	Reviewed & tested by the community	» Fixed

Changes commited to GIT (diff)

Thx for help and review patch.

Greetings

Comment #7

17 July 2012 at 07:21

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #8

mkesicki CreditAttribution: mkesicki commented 12 December 2012 at 13:23

Title:

[D6] Destroy existing instance when trying to replace it

» [D6] Destroys existing instance when trying to replace it

Comment #9

alsammanKhaled CreditAttribution: alsammanKhaled commented 15 June 2022 at 05:42

Issue summary:

View changes

I am not sure if this is related or not but i am using drupal 9 and i am having a smiliar issue. when i add my ckeditor using js and remove the old one it would give this error "ckeditor.js?v=4.17.1:350 Uncaught TypeError: Cannot read properties of null (reading 'unselectable')"
when inspecting the element the ckeditor is not rendered. however without js it would render everything. I end up with a textfield element that is empty whe i use my js. is this related to here or should i make an issue or search somethinge different? any guidance is appreciated.