The variable typing in MigrateMetatagsquickFieldHandler::prepare() is not the same as MigrateFieldHandler::prepare().

MigrateFieldHandler::prepare()

public function prepare(stdClass $entity, array $field_info, array $instance, array $values);

MigrateMetatagsquickFieldHandler::prepare()

public function prepare($entity, array $field_info, array $instance, array $values)

Notice the missing stdClass variable type for $entity.

I haven't had this be an issue on all sites but on some it's caused a fatal error when running update.php and other admin functions. So it may be a php setting that causes more strictness on the ones where it throws an error. Either way it's safer to do it correctly then not.

Patch to come.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arcaneadam’s picture

Patch Attached

arcaneadam’s picture

Status: Active » Needs review
valthebald’s picture

Status: Needs review » Fixed

Thanks for pointing this out!
Committed to 7.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.