Limit Products fields in the Product display "Manage Display" to the field of selected Product types [#1672118]

The Manage Display of a Product Display type should check the Referenced Product Type field to only show the available fields for the selected Product Types.

source issue: #1629966: Check the allowed types of referenced product when managing content type display.

Comment	File	Size	Author
#3	referenced_product_types_fields_for_display-1672118-3.patch	1.62 KB	vasike
#3
#1	referenced_product_types_fields_for_display-1672118-1.patch	2.96 KB	vasike
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

vasike

Ramnicu Valcea

CreditAttribution: vasike commented 5 July 2012 at 12:22

Status:

Active

» Needs review

File	Size
referenced_product_types_fields_for_display-1672118-1.patch	2.96 KB

here is a patch
it limits the fields to the referenced product types, based on the instance of the product_reference field
and all fields of all product types if there is no product type selected.

Comment #2

bojanz CreditAttribution: bojanz commented 5 July 2012 at 14:18

+        $referenceable_types = $field_instance['settings']['referenceable_types'];
+        foreach ($referenceable_types as $key => $referenceable_type) {
+          if ($referenceable_type) {
+            $product_types[] = $referenceable_type;
+          }
+        }

You can replace this with

$referenceable_types = array_filter($field_instance['settings']['referenceable_types']);

Might make sense to not duplicate the field adding code, and just give it a list of all product bundles if the list of referenceable types is empty, but that's more of a code style issue...

Comment #3

vasike

Ramnicu Valcea

CreditAttribution: vasike commented 5 July 2012 at 14:49

File	Size
referenced_product_types_fields_for_display-1672118-3.patch	1.62 KB

thank you Bojan.
what about this new patch?

Comment #4

bojanz CreditAttribution: bojanz commented 5 July 2012 at 22:03

Much better! Other than perhaps documentation tweaks, this seems ready.

Comment #5

bojanz CreditAttribution: bojanz commented 31 July 2012 at 15:59

Status:

Needs review

» Reviewed & tested by the community

Let's get this to Ryan.

Comment #6

bojanz CreditAttribution: bojanz commented 6 August 2012 at 16:24

Issue tags:

+kickstart blocker

Tagging.

Comment #7

rszrama CreditAttribution: rszrama commented 25 September 2012 at 22:05

Status:

Reviewed & tested by the community

» Fixed

Touched up the comments and also used commerce_product_types() to get a list of "all" product types in the event no filter has been applied. For some reason as written it wasn't working in my testing.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/957a599