Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up
Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:
/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */
Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.
Files: user/user.js, user/user.permissions.js
Comment | File | Size | Author |
---|---|---|---|
#7 | core-jshint-user-1684880-7.patch | 568 bytes | nod_ |
#2 | user-js.patch | 2.67 KB | droplet |
Comments
Comment #1
nod_Comment #2
droplet CreditAttribution: droplet commentedComment #3
nod_Apply, still works and JSHint is happy.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #6
nod_New JSHint config #1995996: Update JSHint configuration.
Comment #7
nod_Comment #8
droplet CreditAttribution: droplet commentedReal tested, working :)
Comment #9
alexpottCommitted bdf0286 and pushed to 8.x. Thanks!