Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The attached patch removes an unused setting of the variable $http_protocol and tidies up another use of the variable. No functional changes.
Comment | File | Size | Author |
---|---|---|---|
#11 | 1494676-remove_unused_http_protocol.patch | 430 bytes | Cameron Tod |
#7 | http_protocol.patch | 450 bytes | Liam Morland |
#4 | http_protocol.patch | 782 bytes | Liam Morland |
#3 | http_protocol.patch | 782 bytes | Liam Morland |
#2 | http_protocol.patch | 782 bytes | Liam Morland |
Comments
Comment #2
Liam MorlandComment #3
Liam MorlandUpdated patch rolled against latest D8.
Comment #4
Liam MorlandReroll.
Comment #5
Lars Toomre CreditAttribution: Lars Toomre commentedLooks good to me and passes the bot!
Comment #6
webchickWhile this is technically valid PHP to throw a ternary operation in the middle of a string, it's a little strange compared to what we do elsewhere. I actually find the former code a bit easier to read. :\
I would recommend just a patch to get rid of the bunk variable in the if ($base_url) check alone.
Comment #7
Liam MorlandOK, see attached.
Comment #8
Cameron Tod CreditAttribution: Cameron Tod commentedLooks good to me. I was just about to post this exact patch.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #10
Cameron Tod CreditAttribution: Cameron Tod commentedAdding tags.
Comment #11
Cameron Tod CreditAttribution: Cameron Tod commentedHere's a quick backport.
Comment #12
Liam MorlandLooks good. Thanks.
Comment #13
xjmComment #14
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/5b13080