API page: http://api.drupal.org/api/drupal/modules%21taxonomy%21taxonomy.module/fu...

Enter a descriptive title (above) relating to taxonomy_term_load, then describe the problem you have found:

If $tid not found, FALSE is returned. NULL would be also assumable.

CommentFileSizeAuthor
#10 taxonomy_term_load-does-not-1689426-10.patch526 bytesmjonesdinero
#6 taxonomy_term_load-does-not-1689426-6.patch582 bytesmjonesdinero
#4 taxonomy_term_load-does-not-1689426-4.patch578 bytesmjonesdinero
#2 taxonomy_term_load-does-not-1689426-2.patch514 bytesmjonesdinero
added_Return_message1.patch539 bytesro-no-lo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Return on failure missing » taxonomy_term_load() does not document return value on failure
Status: Active » Needs work
Issue tags: +Novice, +Needs backport to D7

Thanks for the patch! See http://drupal.org/node/1689394#comment-6244396 for a note on patch formatting.

So this patch needs to be rerolled using Git, and also:
- Line wrapping -- move the added text up to the previous line, and wrap at 80 characters.
- Add "the" to "FALSE if *the* term was not found.".

mjonesdinero’s picture

mjonesdinero CreditAttribution: mjonesdinero commented
Status: Needs work » Needs review
FileSize
taxonomy_term_load-does-not-1689426-2.patch514 bytes

re roll the patch..

Status: Needs review » Needs work

The last submitted patch, taxonomy_term_load-does-not-1689426-2.patch, failed testing.

mjonesdinero’s picture

mjonesdinero CreditAttribution: mjonesdinero commented
Assigned: Unassigned » mjonesdinero
Status: Needs work » Needs review
FileSize
taxonomy_term_load-does-not-1689426-4.patch578 bytes

sorry about the last patch submitted it was for d7 i thought it is for d7 but also in d8..

attach is the patch now for d8.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks!

This line is missing a space:

+ *   A taxonomy term entity. Results are statically cached.FALSE if the term

And maybe it would be better to say "... term entity, or FALSE if the term ..." rather than putting that at the end?

mjonesdinero’s picture

mjonesdinero CreditAttribution: mjonesdinero commented
FileSize
taxonomy_term_load-does-not-1689426-6.patch582 bytes

okie re-rolled the patch, git pull first for the update on the patch commited.

attach is the updated patch now..

mjonesdinero’s picture

mjonesdinero CreditAttribution: mjonesdinero commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks! I'll get it committed shortly.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 8.x. The patch doesn't apply to 7.x, so we need a reroll.

mjonesdinero’s picture

mjonesdinero CreditAttribution: mjonesdinero commented
Status: Patch (to be ported) » Needs review
FileSize
taxonomy_term_load-does-not-1689426-10.patch526 bytes

re-rolled the patch for D7

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Thanks! I'll get this committed soon.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x now too. Thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.