Make admin compatible with jquery 1.6+ [#1334804]

Attached is a patch. This does actually break compatibility with earlier jquery versions because it uses a method called .prop. I'm working on a backwards compatible patch.

Comment	File	Size	Author
#9	admin_jquery_update-1334804-9.patch	3.73 KB	idflood
#7	admin_jquery_update-1334804-7.patch	3.24 KB	idflood
#6	1334804-admin-jquery-updated-6.patch	2.93 KB	populist
#3	admin-js.patch	3.12 KB	artfulrobot
#2	compat_jq_1.6-1334804-2.patch	1.88 KB	pdrake
#1	compat_jq_1.6-1334804-1.patch	2.09 KB	MrMaksimize
	compat_jq_1.6-issue-comment.patch	0 bytes	MrMaksimize

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

MrMaksimize CreditAttribution: MrMaksimize commented 7 November 2011 at 22:55

File	Size
compat_jq_1.6-1334804-1.patch	2.09 KB

Oops that one came up blank. here's a new and improved one.

Comment #2

pdrake CreditAttribution: pdrake commented 1 February 2012 at 03:06

File	Size
compat_jq_1.6-1334804-2.patch	1.88 KB

Here is a re-roll of this patch against the latest 6.x-2.x, relative to module root.

Comment #3

artfulrobot CreditAttribution: artfulrobot commented 17 February 2012 at 16:22

File	Size
admin-js.patch	3.12 KB

Thanks! I'd found and fixed the missing quotes around the href selector, but missed the prop().

Here's my patch which includes the href fix, the prop fix, and adds a fix for the breadcrumbs mechanism (which used on a workaround for jquery 1.2 that didn't seem necessary with 1.7)

Against: 7.x-2.0-beta3

Comment #4

dcyuri7 CreditAttribution: dcyuri7 commented 30 May 2012 at 01:39

thanks this helped me :)

Comment #5

jackbravo CreditAttribution: jackbravo commented 18 July 2012 at 17:19

Version:	6.x-2.x-dev	» 7.x-2.0-beta3
Status:	Active	» Reviewed & tested by the community

Yes this works for me with jquery_update and admin. Without this patch I get "Syntax error, unrecognized expression: [href=/admin]".

Comment #6

populist CreditAttribution: populist commented 23 October 2012 at 23:02

File	Size
1334804-admin-jquery-updated-6.patch	2.93 KB

Here is a quick reroll of #3 to cleanly apply. I also tested this and think its great.

Comment #7

idflood CreditAttribution: idflood commented 22 November 2012 at 09:40

Status:

Reviewed & tested by the community

» Needs review

File	Size
admin_jquery_update-1334804-7.patch	3.24 KB

Patch in #6 doesn't apply cleanly on 7.x-2.x so I manually rerolled it. There was two lines about the href which were already ok and I added a fix in admin.devel.js.