JSHint autocomplete.js [#1684792]

Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: autocomplete.js

Comment	File	Size	Author
#7	core-jshint-autocomplete-1684792-7.patch	919 bytes	nod_
#7
#2	autocomplete-jshint.patch	1.34 KB	droplet
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

nod_

French

Lille

CreditAttribution: nod_ commented 14 July 2012 at 14:39

core/misc/autocomplete.js: line 228, col 52, Don't make functions within a loop.
core/misc/autocomplete.js: line 229, col 55, Don't make functions within a loop.
core/misc/autocomplete.js: line 230, col 56, Don't make functions within a loop.
core/misc/autocomplete.js: line 315, col 9, 'alert' is not defined.

Comment #2

droplet CreditAttribution: droplet commented 15 July 2012 at 21:24

Status:

Active

» Needs review

File	Size
autocomplete-jshint.patch	1.34 KB

Comment #3

nod_

French

Lille

CreditAttribution: nod_ commented 19 July 2012 at 12:14

Status:

Needs review

» Postponed

Waiting on #675446: Use jQuery UI Autocomplete to get in to avoid reroll.

Comment #4

nicothezulu CreditAttribution: nicothezulu commented 28 September 2012 at 09:22

Issue tags:

-JavaScript clean-up

When u have input fields with the same id for multiple autocomplete fields over a panel, or page, or smthg autocomplete fails.

You need to add the following lines in autocomplete.js:

Drupal.behaviors.autocomplete = function (context) {
  var acdb = [];
  $('input.autocomplete:not(.autocomplete-processed)', context).each(function () {
     var parentForm = $(this).closest("form"); //ADD THIS
     var idParent = '#'+parentForm.attr('id'); //ADD THIS
     var uri = this.value;
     if (!acdb[uri]) {
        acdb[uri] = new Drupal.ACDB(uri);
     }
      var input = $(idParent+' #' + this.id.substr(0, this.id.length - 13)).attr('autocomplete', 'OFF')[0]; //CHANGE THIS
     .
     .
     .

I know its a separate issue, than this post...

Comment #5

nod_

French

Lille

CreditAttribution: nod_ commented 28 September 2012 at 09:44

Issue tags:

+JavaScript clean-up

If you know it, please create a new issue, this has nothing to do with JSHint. Thanks.

Restoring tags.

Comment #6

nod_

French

Lille

CreditAttribution: nod_ commented 6 June 2013 at 12:26

Status:

Postponed

» Needs work

Let's get rid of that, the other issue isn't moving very much.

core/misc/autocomplete.js: line 230, col 52, Don't make functions within a loop.
core/misc/autocomplete.js: line 231, col 55, Don't make functions within a loop.
core/misc/autocomplete.js: line 232, col 56, Don't make functions within a loop.