Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It fails with:
Drush command terminated abnormally due to an unrecoverable error. Error: Call to a member function get_parameters() on a non-object in /data/all/001/openchurch-7.x-1.10-alpha1-7.14.1/profiles/openchurch/modules/contrib/media_vimeo/includes/themes/media_vimeo.theme.inc, line 16
And then even fails to delete semi-installed site.
Comment | File | Size | Author |
---|---|---|---|
#13 | openchurch-media_vimeo_fix-1585348-6156106-1.patch | 717 bytes | drupalninja99 |
#8 | openchurch-media_vimeo_fix-1585348-6156106.patch | 676 bytes | drupalninja99 |
#8 | openchurch-media_youtube_fix-1585348-6156106.patch | 656 bytes | drupalninja99 |
Comments
Comment #1
omega8cc CreditAttribution: omega8cc commentedAnd after removing media_vimeo from dependencies, another one:
Comment #2
omega8cc CreditAttribution: omega8cc commentedThe workaround is to comment out this one line:
;dependencies[] = openchurch_video_demo_content
Comment #3
drupalninja99 CreditAttribution: drupalninja99 commentedThat seems odd seeing as how I have installed this on Omega8.
Comment #4
drupalninja99 CreditAttribution: drupalninja99 commentedAre you running the drush make or are you downloading the tarball? I have installed several versions on omega8 from the tarball without issue. I suppose you could try 1.10-alpha3
Comment #5
drupalninja99 CreditAttribution: drupalninja99 commentedOh I am seeing this in on another project. Hmm.
Comment #6
drupalninja99 CreditAttribution: drupalninja99 commentedI am getting this know, I am going to have to fix this.
Comment #7
drupalninja99 CreditAttribution: drupalninja99 commentedComment #8
drupalninja99 CreditAttribution: drupalninja99 commentedAdding patches which fix the site install problem.
Comment #9
drupalninja99 CreditAttribution: drupalninja99 commentedI am adding a simple patch that just wraps an is_object condition around the $wrapper object. What is happening is that for whatever reason the site install calls a theme preprocessor function and I suppose the wrapper object just isn't ready yet so it breaks the installation. Adding this one fix seems to fix the issue which is only a site installation issue.
I am going to add to dev and test there.
Comment #10
drupalninja99 CreditAttribution: drupalninja99 commentedAdded to 7.x-1.x HEAD which should update the 1x dev tarball by tonight. I can then do an end to end test there.
Comment #11
drupalninja99 CreditAttribution: drupalninja99 commentedChanging to needs review
Comment #12
drupalninja99 CreditAttribution: drupalninja99 commentedThose patches aren't working so I am going to need to fix it.
Comment #13
drupalninja99 CreditAttribution: drupalninja99 commentedUploading a new patch with the correct media_vimeo patch.
Comment #14
drupalninja99 CreditAttribution: drupalninja99 commentedOK I learned how to checkout a specific tag in git which is what I should have done the first time when I patched media_vimeo. Previously I had patched the dev version of the file instead of beta5. Anywho dev should be repaired the next time it's packaged.
Comment #15
omega8cc CreditAttribution: omega8cc commentedThanks, I will try it out.
Comment #16
drupalninja99 CreditAttribution: drupalninja99 commentedI need to test the dev download end to end but it did look like the packager patched media_vimeo correctly this time.
Comment #17
drupalninja99 CreditAttribution: drupalninja99 commentedThis looks like it is working now, will push to alpha4.
Comment #18
drupalninja99 CreditAttribution: drupalninja99 commentedOK I have tagged 7.x-1.10-alpha4 and so that version will fix the issue.
Comment #19
drupalninja99 CreditAttribution: drupalninja99 commentedChanging to fixed