Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The same node is listed multiple times in the "My Edits" list:
Comment | File | Size | Author |
---|---|---|---|
#5 | workbench-my_views_duplicates-1630702-5.patch | 18.76 KB | kbentham |
workbench_dupes_my_edits.png | 34.01 KB | tsvenson |
Comments
Comment #1
barraponto CreditAttribution: barraponto commentedAre they different nodes? I faced a similar issue with overlay + rules duplicating nodes and polluting my views, including workbench.
Comment #2
tsvenson CreditAttribution: tsvenson commentedIts the same node.
Comment #3
barraponto CreditAttribution: barraponto commentedOK, upon closer look, that view lists revisions (not nodes), therefore it is supposed to display the same node several times if it has been edited several times. In order to further debug, try adding the "Content revision: Vid" field. Each row should have a different vid (meaning a different revision). If you want to check what changed in each revision, try the Diff module.
The "Last updated" field is confusing, though. It might seem that it refers to when that revision was created, but that's not the case: it actually says when the node was last updated. That's why they all show the same date, since they're edits to the same node.
I suggest ditching the "Content: updated date" field for "Content revision: updated date", since it would be more useful. Also, there's no need for "Action Links" (it just doesn't work) and "Revised by" (this is the "My edits" view, the value here will always be the same => the logged in user).
Comment #4
kbentham CreditAttribution: kbentham commentedThis patch should take care of at least some of the confusion with the duplicates. I have changed the title so it will now display the title of the revision as well as link to the revision instead of just the node. The "Last updated" now displays the update date of the revision instead of the node and I have also removed "Revised by".
Comment #5
kbentham CreditAttribution: kbentham commentedIt would be helpful if I actually uploaded the patch.
Comment #6
stevectorSince the edit link is broken: #1388220: Actions Missing in My Edits, I'm committing a version that just removes that actions column. That can be resolved separately in the other issue.
http://drupalcode.org/project/workbench.git/commit/91135492c1f1c924f2277...
Comment #7
barraponto CreditAttribution: barraponto commentedWhat about the "revised by" column? When we're lookin at the "my reviews" table, I assume they're all mine, right? No need for that column.
Comment #8
kbentham CreditAttribution: kbentham commentedYes because all of the item in the table were revised by the user looking at them it was a little redundant.
Comment #9
brunodboWould it make sense to filter the 'My edits' view by 'Workbench moderation: Current revision'? Might clear things up more for editor users. We could add a link to 'node/%nid/moderate' to every views row, to point users to other revisions if they need them.
Comment #10
brunodboNevermind: making the change suggested in #9 depends on having WB moderation intstalled ...
Comment #12
Voroz CreditAttribution: Voroz commentedPatch wokrs fine for me, but it remains an issue in My Drafts: The title is still the node's title instead of the revision title.
Comment #13
barraponto CreditAttribution: barraponto commentedThen we're back to needs work.
Comment #14
hass CreditAttribution: hass commentedPossibly fixed in #1792144: "My Edits" View is broken
Comment #15
rv0 CreditAttribution: rv0 commentedI can confirm #14 fixes it for me.
Comment #16
agentrickardClosing again in favor of the other issue.
Comment #16.0
agentrickardUsed the a tag instead of img...