Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When updating the machine name from a display, and the blocks module is not installed. You get a fatal error about the blocks update query.
Comment | File | Size | Author |
---|---|---|---|
#6 | 1621236-views-disabled-block.patch | 566 bytes | andypost |
#2 | 1621236.patch | 1.04 KB | dawehner |
#1 | blocks_fatal_error-1621236-1.patch | 641 bytes | nils.destoop |
Comments
Comment #1
nils.destoop CreditAttribution: nils.destoop commentedAttached is a patch
Comment #2
dawehnerActually i think that the block display might not appear at all if there is no block module installed, though this might cause a lot of additional problems if we do that.
Lets go with this patch, thanks for writing one! Just added a comment + proper indentation.
Comment #3
dawehnerThanks for the patch! Committed it to 7.x-3.x and 8.x-3.x
Comment #4
andypostYou better use db_table_exists() because module could be installed but disabled
Comment #5
dawehnerFeel free to post a follow-up patch.
Comment #6
andypostSuppose code comment is ok, just need to check block's table.
module_exists() returns TRUE only if module installed and enabled
Comment #7
dawehnerI'm not sure, but why would you want to update the block table if you don't have the block module installed ...
At least in most cases you expect that the table data is not changed anymore once you have disabled a module.
Comment #8
dawehnerAfter some dicussions i realized you were right! Committed to both 7.x-3.x and 8.x-3.x
Comment #9
andypostWe need this because of block module could be installed but disabled