Some CIM Orders Stuck In Checkout [#1415670]

When paying with a saved card, many (though not all) orders are getting stuck in the checkout stage. The transaction is successful (and logged to the order as such), but the order status is never updated and a confirmation email never sent. It's not all orders, but I haven't been able to find an obvious difference between the good ones and the ones causing problems.

Comment	File	Size	Author
#5	1415670-prevent_payment_callback_when_form_errors_present.patch	832 bytes	andyg5000
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rszrama CreditAttribution: rszrama commented 26 January 2012 at 03:05

Are you sure the transaction is successful? Could it be reporting a false positive inside of Drupal Commerce?

Comment #2

dabblela CreditAttribution: dabblela commented 26 January 2012 at 15:46

Thanks for getting back on this. The transaction is successful and the card is charged. I believe the problem is that I have a one page checkout (no review) and clicking submit even if there are required fields missing or other form errors will still attempt a transaction. The form errors are reported to the user, but the transaction still goes through and the order balance is zeroed. Since the order balance is zero, subsequent transactions don't go through and the user can't complete checkout.

Comment #3

rszrama CreditAttribution: rszrama commented 26 January 2012 at 22:23

Sounds like that'd do it. The module doesn't do anything atm to accommodate such a scenario

Comment #4

dabblela CreditAttribution: dabblela commented 31 January 2012 at 18:05

Would it break anything to add something like:

if ($err = form_get_errors()) {
    return FALSE;
  }

Comment #5

andyg5000

he/him

English

North Carolina, USA

CreditAttribution: andyg5000 commented 25 July 2012 at 17:46

Project:	Commerce Authorize.Net	» Commerce Core
Component:	Code	» Payment

File	Size
1415670-prevent_payment_callback_when_form_errors_present.patch	832 bytes

Form errors on other elements (ie: billing information) do not prevent payment submission when payment form is on the same pane.

Comment #6

dabblela CreditAttribution: dabblela commented 27 July 2012 at 14:39

Status:

Active

» Reviewed & tested by the community

This looks great to me.

Comment #7

rszrama CreditAttribution: rszrama commented 29 September 2012 at 02:31

Status:

Reviewed & tested by the community

» Fixed

Yep, great patch. I added in a warning message so the customer knows that their payment will not be processed until all errors on the page have been addressed.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/044ce3d