When Drupal 7.13 was released adding forum_update_7011(), it looks like it was left outside the updates-7.x-extra documentation group.

This patch fixes that.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

Ummm... OK... That group doesn't have any description:
http://api.drupal.org/api/drupal/modules!system!system.install/group/upd...
but I guess it is the updates that are between 7.x versions, as opposed to:
http://api.drupal.org/api/drupal/modules!system!system.install/group/upd...

Are there other updates that should be added to this group, along with this patch?

David_Rothstein’s picture

Looks like there might be a bunch. I just tried installing Drupal 7.0, enabling all core modules, then updating to Drupal 7.x and running drush updatedb. Here's what I got:

system module : 
  7070 -   Remove the obsolete 'drupal_badge_color' and 'drupal_badge_size' variables. 
  7071 -   Add index missed during upgrade, and fix field default. 
  7072 -   Remove the obsolete 'site_offline_message' variable.   @see update_fix_d7_requirements() 
  7073 -   Add binary to {file_managed}, in case system_update_7034() was run without  it. 

block module : 
  7008 -   Update database to match Drupal 7 schema. 

color module : 
  7001 -   Warn site administrator if unsafe CSS color codes are found in the database. 

comment module : 
  7007 -   Add an index to the created column. 
  7008 -   Update database to match Drupal 7 schema. 
  7009 -   Change the last_comment_timestamp column description. 

field module : 
  7002 -   Split the all-inclusive field_bundle_settings variable per bundle. 

forum module : 
  7002 -   Add new index to forum_index table. 
  7003 -   Rename field to 'taxonomy_forums'. 
  7011 -   Update {forum_index} so that only published nodes are indexed. 
  7012 -   Add 'created' and 'last_comment_timestamp' indexes. 

image module : 
  7001 -   Rename possibly misnamed {image_effect} table to {image_effects}. 
  7002 -   Add width and height columns to image field schema and populate. 
  7003 -   Remove the variables that set alt and title length since they were not  used for database column size and could cause PDO exceptions. 
  7004 -   Use a large setting (512 and 1024 characters) for the length of the image alt  and title fields. 

list module : 
  7002 -   Re-apply list_update_7001() for deleted fields. 

locale module : 
  7003 -   Update "language_count" variable. 
  7004 -   Remove duplicates in {locales_source}. 

menu module : 
  7000 -   Migrate the "Default menu for content" setting to individual node types. 
  7001 -   Rename "Primary Links" and "Secondary Links" to their Drupal 7 equivalents. 
  7002 -   Rename the primarysecondary menu blocks to match previously renamed menus. 
  7003 -   Add missing custom menus to active menus list. 

node module : 
  7011 -   Update the database from Drupal 6 to match the schema. 
  7012 -   Switches body fields to untranslatable while upgrading from D6 and makes them language neutral. 
  7013 -   Change {node}.vid default value from 0 to NULL to avoid deadlock issues on MySQL. 

poll module : 
  7004 -   Update the database to match the schema. 

trigger module : 
  7001 -   Increase the length of the "hook" field to 78 characters.   This is a separate function for those who ran an older version of  trigger_update_7000() that did not do this. 
  7002 -   Renames nodeapi to node. 

user module : 
  7016 -   Update the database to match the schema. 
  7017 -   Update email templates to use new tokens.   This function upgrades customized email templates from the old !token format  to the new core tokens format. Additionally, in Drupal 7 we no longer e-mail  plain text passwords to users, and there is no token for a plain text  password in the new token system. Therefore, it also modifies any saved  templates using the old '!password' token such that the token is removed, and  displays a warning to users that they may need to go and modify the wording  of their templates. 
  7018 -   Ensure there is an index on {users}.picture. 
jhodgdon’s picture

Title: Forum module extra D7 updates aren't in the correct documentation group » Extra D7 updates aren't in the correct documentation group
Status: Needs review » Needs work
Issue tags: +Novice

That is an excellent way to check! All of those should therefore be in the "extra updates" group, and we should also make sure that none of those are in the "6-7 updates" group. (URLs on api.drupal.org are in comment #1).

That sounds like a good Novice patch project...

dsdeiz’s picture

FileSize
8.13 KB

field module :
7002 - Split the all-inclusive field_bundle_settings variable per bundle.

This seems to be already on the "Extra system updates for 7.x" group.

Sorry, I'm a little bit confused. I see forum_update_7011 in between the "@addtogroup updates-7.x-extra" and "@} End of "addtogroup..." but I'm not sure why it's not listed here.

menu module :
7000 - Migrate the "Default menu for content" setting to individual node types.
7001 - Rename "Primary Links" and "Secondary Links" to their Drupal 7 equivalents.
7002 - Rename the primarysecondary menu blocks to match previously renamed menus.
7003 - Add missing custom menus to active menus list.

Seems like these are already listed on the group.

Attached my first attempt.

dsdeiz’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Regarding forum_update_7011, it looks like your patch fixed the problem there correctly.

Regarding field.module, it looks like 7002 is already listed on http://api.drupal.org/api/drupal/modules!system!system.install/group/upd...

Regarding menu.module - I agree these are already listed. The list in #2 was the list of all that *should* be listed -- I don't think David was trying to say they were all missing, just that this was the list of what should be there and we need to make a patch to make sure they're all there.

Anyway... I haven't checked this patch completely yet, but it looks like you have the right idea. I'll try to give it a more complete review soon unless someone else does first. Thanks!

jhodgdon’s picture

Status: Needs review » Fixed

It all checked out OK -- thanks for the patch! Committed to 7.x.

Follow-up issue:
#1688020: The Extra System Updates group has no description and wrong name

Automatically closed -- issue fixed for 2 weeks with no activity.