Just a heads up/ FYI #787644: Export UI - unified ui for exportables . We need to make sure Openlayers can implement it's needs as-well..
Status
- Openlayers Maps: 100%
- Openlayers Styles: 100%
- Openlayers Layers: 100%
- Code cleanup, remove useless hooks and menu entries: 50%
- 'name' field is not a machine name, automatically filled up with the title.
- Fix tests: 100%
Openlayers Maps
The UI is working, the operations: Add, Edit, Delete, Clone are working perfectly.
Screenshot WIP: http://www.webpagescreenshot.info/img/15181-83201235142PM and http://www.webpagescreenshot.info/img/163362-83201282023PM
Openlayers Styles
The UI is working, the operations: Add, Edit, Delete, Clone are working perfectly.
Screenshot WIP: http://www.webpagescreenshot.info/img/697743-83201235249PM
Openlayers Layers
The UI is working, the operations: Add, Edit, Delete, Clone are working perfectly.
Screenshot WIP: http://www.webpagescreenshot.info/img/486222-83201235215PM
Bugs
- Solved:
When I try to edit or add a layer, I get the following: PHP Fatal error: Class 'openlayers_views_vector' not found in .... (did you have the openalyers_views module on when you made the patch? If I turn it off, it works alright.) - Solved: I was ale to save a layer that had no name, machine_name, description, or layer type.
- Solved: Should fix tests.
- Solved: Various warnings.
- Solved: There's no Preview button on styles.
- Solved: There's no Preview button on maps.
- Solved: Not a big deal, but the higher level menu items don't persist when you add, edit, save and item.
Comment | File | Size | Author |
---|---|---|---|
#39 | 0001-Issue-814220-Enable-CTools-Export-UI.patch | 67.3 KB | Pol |
#37 | 814220.diff.patch | 45.5 KB | Pol |
#36 | 0001-Issue-814220-CTools-Export-UI.patch | 65.27 KB | Pol |
#35 | 0001-Issue-814220-CTools-Export-UI.patch | 65.31 KB | Pol |
#34 | 0001-Issue-814220-Use-CTools-Export-UI-for-Layers-Maps-an.patch | 65.73 KB | Pol |
Comments
Comment #1
zzolo CreditAttribution: zzolo commentedThanks @Amitaibu for the heads up. It looks exciting. Marking as postponed until there is a solid release with this new code.
Comment #2
amitaibuPatch is now committed :)
Comment #3
zzolo CreditAttribution: zzolo commentedThanks @Amitaibu. I think its best if we do not include this until a release of CTools has this change in there. Also, is there any documentation on how to implement this (as opposed to trying to piece it all together with issue comments and code)?
Comment #4
amitaibu1) Help file.
2) You can see the panels-stylizer plugin in the Panels DEV package, to see how the base class of the plugin can be extended.
3) Ping me on IRC :)
Comment #5
zzolo CreditAttribution: zzolo commentedtagged as beta blocker
Comment #6
tmcw CreditAttribution: tmcw commentedI don't think that this should be tagged as beta blocker. It's a great step, and I've started work on very large patch that moves styles to export-ui. But, the development that's needed here is the kind of stuff that's suited for a 2.1 or a dev branch of sorts: this is not the kind of thing we want to 'finish up' before releasing a beta, it's something that we should do after that.
Comment #7
tmcw CreditAttribution: tmcw commentedComment #8
zzolo CreditAttribution: zzolo commentedMoving to D7.
Comment #9
nod_status on that ? Is it the same thing as clone/edit/add links ?
Comment #10
zzolo CreditAttribution: zzolo commentedYeah, CTools provides some UI help for exportable objects. We should utilize this.
Comment #11
PolIf this is the same thing as the links add/edit/clone, we can close the issue ?
Comment #12
zzolo CreditAttribution: zzolo commentedIt is those links and more, but CTools provides a lot of code for this that can be utilized. It's not really a high priority but it should cut back on the amount of code.
Comment #13
PolI think we really should dig up in that direction.
Do you have a module who can be an example of what to do ?
Thanks Alan !
Comment #14
zzolo CreditAttribution: zzolo commentedHere's some stuff. I haven't looked at it in awhile so not sure how documented it is.
http://www.sthlmconnection.se/blog/exportable-configuration-ctools-revis...
http://drupal.org/node/855392
Comment #15
PolVery interesting to get started too: http://drupal.org/project/ctex
Work in progress: http://www.webpagescreenshot.info/img/29311-822012102242AM
Now I have to find how to add this page in replacement of the default Maps tab.
Comment #15.0
PolUpdated issue summary.
Comment #15.1
PolUpdated issue summary.
Comment #15.2
PolUpdated issue summary.
Comment #15.3
PolUpdated issue summary.
Comment #16
PolThings are moving, Maps and Styles are almost done it's working perfectly until now.
The last part is the Layer part.
We need to think further for the 'Add New Layer' form.
Currently we have a 'in-between' page where we have to select the kind of layer to add.
How to do that using CTools Export UI framework ?
Comment #17
PolFirst patch.
The "Layers" part is not yet done.
Comment #18
PolComment #20
PolLayers part is done.
Comment #22
PolPatch with the files. I forgot them in the previous one.
Comment #24
PolAdd 'Clone' for Layers.
Comment #24.0
PolUpdated issue summary.
Comment #26
zzolo CreditAttribution: zzolo commentedThis patch breaks a lot of tests.
Comment #27
zzolo CreditAttribution: zzolo commentedIts pretty awesome how much functionality you can get out of this. It's definitely getting there, but there are still some rough edges.
Comment #27.0
zzolo CreditAttribution: zzolo commentedUpdated issue summary.
Comment #27.1
PolUpdated issue summary.
Comment #27.2
PolUpdated issue summary.
Comment #28
PolFixed a couple of bugs and enabled the machine name.
WIP: http://www.webpagescreenshot.info/img/668441-832012103806AM
Comment #29
PolComment #30.0
(not verified) CreditAttribution: commentedUpdated issue summary.
Comment #31
PolComment #32.0
PolUpdated issue summary.
Comment #32.1
PolUpdated issue summary.
Comment #33
PolLooks like we have winner here !
Comment #34
PolNew patch, remove useless functions, cleaned up a bit.
I added the missing columns in the tables, so it looks like the version without the patch. Screenshots are updated.
Comment #34.0
PolUpdated issue summary.
Comment #34.1
PolUpdated issue summary.
Comment #35
PolThis patch enable the preview button for the Styles.
Comment #35.0
PolUpdated issue summary.
Comment #36
PolRemove #id property in the forms if the machine name is after the source field.
See #990218: Machine name field throws notices if before source field..
Comment #37
PolThis patch enable preview for Maps.
Comment #39
PolComment #39.0
PolUpdated issue summary.
Comment #40
PolNew patch, including a new update function to rebuild the menu_links and fix the breadcrumb.
Fixed by Dave Reid during the Drupalcon Munich 2012.
Comment #40.0
PolUpdated issue summary.
Comment #41
PolCommitted.
Comment #42
jeffschulerYay! :)
Comment #44
jeffschulerLayer options are no longer loaded and shown in the layer edit form.
For instance, save a GeoJSON layer then re-edit it. The URL, Data, and UseBBOX settings don't load.
Comment #45
friedjoff CreditAttribution: friedjoff commentedThere is already #1761768: Layer options don't load with a patch.
Comment #46
PolI spotted a nasty bug and I have no idea on what's the way to solve it, probably because I need to sleep ;-)
Before using CTools Export UI, forms where using custom submit functions. In this case, this is the layer form in OpenLayers 7.x-2.0-beta2.
OpenLayers was handling the way in which objects were stored in the database.
Now that the form submit is handled by CTools, those functions are useless.
It means that the
save()
method is no more called, CTools takes care to save the object into the DB and AFAIK, it's not possible to alter the data before saving them (correct me if I'm wrong).It also means that the class openlayers_layer_type is no more overridable by other modules, like MapBox (Only for the save() method).
MapBox transforms the urls textarea into an array before saving the layer. This is no more working with our CTools implementation.
This is why we have bugs like this and it's the first, I'm pretty sure that there are others.
I need your feedback on this.
Comment #47
PolComment #48.0
(not verified) CreditAttribution: commentedUpdated issue summary.