Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
While adding/editing maps (admin/structure/openlayers/maps/add for example) I am getting next php strict warning
Strict warning: Declaration of openlayers_behavior_boxselect::options_form() should be compatible with that of openlayers_behavior::options_form() in ctools_plugin_get_class() (line 841 of /home/ivica/moje/bin/lampp_new/htdocs/unicef-microsite/sites/all/modules/contrib/ctools/includes/plugins.inc).
Using php 5.3.5, drupal 7.8, ctools 7.x-1.0-rc1 and openlayers 7.x-2.0-alpha2
Comment | File | Size | Author |
---|---|---|---|
#17 | 1278684.patch | 18.02 KB | casey |
#15 | 1278684.patch | 16.13 KB | casey |
#14 | openlayers-fix-strict-warnings-for-method-options_form-1278684-14.patch | 17.12 KB | nod_ |
#13 | Archive.zip | 2.15 MB | lathan |
#10 | openlayers-fix-strict-warnings-for-method-options_form-1278684-10.patch | 19.3 KB | das-peter |
Comments
Comment #1
pivica CreditAttribution: pivica commentedHere is a patch for latest dev.
Comment #2
lathantested patch works :)
also getting a views render issue.
Comment #3
lathanFix for that views render().... in openlayers_views/views/openlayers_views_style_data.inc
change
TO this.... and voila
Comment #4
zzolo CreditAttribution: zzolo commented@jucallme, thanks for the patch! Committed.
Can you actually open another ticket for the Views issue? Also, can you explain why your patch fixes the problem, as I am just not sure why that needs to be done.
Many thanks!
Comment #5
das-peter CreditAttribution: das-peter commentedReopened because there's left a whole bunch of such warnings.
Attached patch contains fixes for all locations where I've found such incompatible method declarations.
Additionally there are some trailing white-space fixes - let me know if you prefer a patch without those.
Comment #6
eMPee584 CreditAttribution: eMPee584 commentedregarding patch #5:
Lo0king g0od, huge improvement to openlayers code quality...
That's a lot of effort you put into the patch, thx das-peter ;)
Comment #7
zzolo CreditAttribution: zzolo commented#5: openlayers-fix-strict-warnings-for-method-options_form-1278684-5.patch queued for re-testing.
Comment #8
zzolo CreditAttribution: zzolo commentedHey @das-peter. Thanks for the patch. Yeah, the white space changes make it hard to review since its a it difficult to see the real changes. Also, it does not apply anymore. Do you mind re-rolling it without the whitespace changes? Thank you.
Comment #9
das-peter CreditAttribution: das-peter commentedHere we go - re-rolled against latest dev and patch created with
--ignore-space-at-eol
.Comment #10
das-peter CreditAttribution: das-peter commentedOops, looks like I forgot to fix two locations - updated patch.
Comment #11
lathansome more are missing... http://cl.ly/1P2N1J37010N1d3g2H34
Comment #12
lathanand some more.. http://cl.ly/1u1j3Y0p0w0Q3v0L3P2o
Comment #13
lathanSorry for the million posts here just have not got the time right now to roll this stuff here is an older port of the alpha with all this stuff fixed and and a working copy of the openlayers_plus module.... (why thats not on d.o. yet i have no clue)
hope this helps..
Comment #14
nod_#10 looks good to me. no more notice running tests. one file didn't apply cleanly. reroll attached.
I haven't tried #13
Comment #15
casey CreditAttribution: casey commentedReroll + fixes for openlayers_views_style_data::render() and openlayers_layer_type_openlayers_views_vector::options_form()
Also, definitely not minor.
Comment #17
casey CreditAttribution: casey commentedComment #18
petsagouris CreditAttribution: petsagouris commented#17: 1278684.patch queued for re-testing.
Comment #19
nod_Thanks! committed to 7.x-2.x and 7.x-3.x
Comment #21
ressa CreditAttribution: ressa commentedI am getting this warning:
Strict warning: Declaration of views_geojson_bbox_argument::query() should be compatible with that of views_handler_argument::query() in require_once() (line 11 of /www/website/sites/all/modules/views_geojson/views/views_geojson_bbox_argument.inc).
Using:
GeoJSON, version = "7.x-1.0-alpha2"
OpenLayers, version = "7.x-2.0-beta1+54-dev"
Should I perhaps open a ticket under GeoJSON in stead?
Comment #22
h3rj4n CreditAttribution: h3rj4n commentedAs said in issue #1365578, the errors are back:
I got this after I update as follows:
OpenLayers (openlayers) 7.x-2.0-beta1+83-dev 7.x-2.0-beta1
Comment #23
mmll CreditAttribution: mmll commentedI got
Strict warning: Declaration of openlayers_layer_type_virtualearth::options_form() should be compatible with openlayers_layer_type::options_form($defaults = Array) funktsioonis ctools_plugin_load_includes() (rida 475 / /var/www/sites/all/modules/ctools/includes/plugins.inc).
after shifting my sites to php 5.4
using openlayers 7.x-2.0-beta3
Comment #24
PolBeta3 doesn't include any virtualearth related stuff, see: http://drupalcode.org/project/openlayers.git/tree/b094f6080ca2eeaf72e0eb...
I suppose this is a bad upgrade.
Comment #25
ace11 CreditAttribution: ace11 commentedI get this when I moved site to production server:
Strict warning: Declaration of openlayers_behavior_stylemap::options_form() should be compatible with openlayers_behavior::options_form($defaults = Array) in ctools_plugin_load_includes() (line 475 of \sites\all\modules\ctools\includes\plugins.inc).
Production server: PHP 5.4.14
Server where I build the site: PHP 5.3.18
And I'm using Open Layers 7.x-2.0-beta5