Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When #1447686: Allow importing and synchronizing configuration when files are updated lands, we'll have a simple config_sync() mechanism.
however, we deferred handling module dependencies and a other issues of ordering of reload operations.
this issue will track that and implement these features.
Comment | File | Size | Author |
---|---|---|---|
#8 | drupal8.config-defer.8.patch | 9.68 KB | sun |
#6 | 1605460_6.patch | 3.02 KB | chx |
#4 | 1605460_4.patch | 2.39 KB | chx |
Comments
Comment #1
sunComment #2
sunThe last patch that implemented the dependency handling and DEFER flag was #105 on
#1447686-105: Allow importing and synchronizing configuration when files are updated
Personally, I think this issue should be postponed until we actually have any config objects with interdependencies though.
(which is blocked on #1668820: Concept, base class, and interface for Configurables (e.g., node types, image styles, vocabularies, views, etc))
Comment #3
sunSomewhat related to dependencies, there is also:
#1677258: Configuration system does not account for API version compatibility between modules
It's filed as a separate issue, because
1) this issue here is mainly talking about interdependencies between multiple config objects
2) that issue is mainly about 1 config object, and 1 module API/version; whereas the config object might have been exported on a site that had a previous module API version installed and the config object is imported on a site that has a different/incompatible module API version installed.
Comment #4
chx CreditAttribution: chx commentedI talked to heyrocker about this and he said that each module should deal on the inside with its own dependencies on the outside we just use the module dependency order. So...
Comment #6
chx CreditAttribution: chx commentedThat's weird , I thought my HEAD was up-to-date. Anyways, the above recalculated modules thrice. Hardly what we want.
Comment #8
sunAttached patch is a 1:1 plain restore of the DEFER code from #1447686: Allow importing and synchronizing configuration when files are updated, extracted from git history.
The code needs to be adjusted all over the place to be functional and compatible with the current config code in HEAD.
However, I think we should definitely base further work on this code, since the defer/dependencies topic actually was the one we discussed most and spent the most time on to figure out. The solution @davidstrauss came up with still makes most sense to me.
Comment #9
chx CreditAttribution: chx commentedI do not get it. This code adds calling MODULE_config_sync but does not remove the existing MODULE_config_import_$op callbacks. I think the latter is now superceded?
Comment #10
sunVery closely related, but different:
#1918926: Module dependencies are not respected when default configuration is imported
Comment #11
alexpottPostponing on #2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall - potentially we might we to implement the defer logic.
Comment #12
mtiftUnpostponed on #2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall
Comment #17
alexpottConfig dependencies got implemented and we use this to build a tree and import in that order.