Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#23 | admin-969916-23.patch | 1.29 KB | c4rl |
#21 | jquery.drilldown.patch | 819 bytes | praestigiare |
#20 | jquery.drilldown.patch | 819 bytes | praestigiare |
#19 | jquery.drilldown.patch | 823 bytes | praestigiare |
#18 | admin-jquery-drilldown-breadcrumb-969916-18.patch | 707 bytes | mdupont |
Comments
Comment #1
HylkeVDS CreditAttribution: HylkeVDS commentedI just ran into the same problem.
jquery.drilldown.js does:
for (var key in breadcrumb) {
Some searching resulted in this:
https://developer.mozilla.org/en/JavaScript/Reference/Statements/For...in
Some toolkits add properties to the array-object. These properties are also iterated over when using for...in.
So better is to change jquery.drilldown.js line 83 to
Comment #2
wizonesolutionsI had to apply this patch on a site I work on to resolve an error in IE, and it worked. I'm setting to RTBC since I don't think this one is going to get much visibility but I think it should be committed to -dev so it makes it into the next official release (or at least an equivalent fix).
Comment #3
Agileware CreditAttribution: Agileware commentedAs HylkeVDS mentioned in #1 the for ... in statement also returns non-elements of the array for some browsers.
Generally for iteration:
For objects:
for (var key in o)
For arrays:
for (var i = 0; i < a.length; i++)
Since we are using an array anyway and not an object the solution mentioned in #1 would be better.
If we must use for ... in another solution would be
This patch is for the solution in #1, which I vote for as being the optimum solution.
Patch applies cleanly to 2.0 and 2.x-dev.
For the record the error message I was getting was:
Comment #4
Agileware CreditAttribution: Agileware commentedTagging
Comment #5
el_reverend CreditAttribution: el_reverend commentedSubscribing.
Comment #6
Nick Robillard CreditAttribution: Nick Robillard commentedPatch works for me. It'd be nice to get this in a release.
(subscribing)
Comment #7
charlie-s CreditAttribution: charlie-s commentedPatch works for me as well, thanks.
Comment #8
mail@victorquinn.com CreditAttribution: mail@victorquinn.com commentedThis patch helps resolve some errors, but it is still very much broken in jQuery 1.6. This drilldown plugin seem to be a hackish mess which hasn't been updated - should the admin module look to adopting something less buggy?
Seems like a waste of resources to have to update this jquery.drilldown.js piece manually with bug fixes every time a new version of jQuery is released.
Comment #9
charlie-s CreditAttribution: charlie-s commentedVictorquinn -- how are you implementing jQuery 1.6 within Drupal 6? Drupal 6 ships with 1.2.
Comment #10
mail@victorquinn.com CreditAttribution: mail@victorquinn.com commentedManually upgraded it, applied patches.
I write custom modules for a college which often makes use of jQuery plugins that require a higher version than 1.2 so I've been forced to upgrade (e.g. jQuery mobile that requires 1.4.3, jsTree which requires 1.4.2, Isotope which requires 1.4.3, etc.). For the most part, nothing else breaks, but the Admin module breaks and breaks hard, which kills javascript on the entire page.
Comment #11
charlie-s CreditAttribution: charlie-s commentedIn my experience a lot of Views ajax calls and things like draggable.js break with jQuery > 1.3. Also, contributed module must be allowed to depend on jQuery 1.2. I've written up a short post on using newer versions of jQuery with Drupal without altering core: http://drupal.org/node/1058168
This (recommended) method allows you to write your custom code to w/e version you want, while simultaneously allowing Drupal, Views, Admin, other contribs to all use jQuery 1.2 without them even noticing each other.
(Just in case any of this information is helpful.)
Comment #12
brunorios1 CreditAttribution: brunorios1 commented+1
Patch in #3 worked for me.
Comment #13
dan_lennox CreditAttribution: dan_lennox commentedPatch in #3 worked for me.
Comment #14
smira CreditAttribution: smira commentedthank you!
confirming patch #3 worked for me as well.
Comment #15
EgbertB CreditAttribution: EgbertB commentedSame issue on a drupal 6.22 site
Suddenly (after a recent upgrade of some modules) got non numerical key values, namely 'filter', and the corresponding breadcrumb object was a function.
I first filtered out non numerical key's, but #3 is a better way to do this
Thanx
Comment #16
muhleder CreditAttribution: muhleder commentedSeeing this problem on 7.x-dev version as well, patch from #3 works here as well.
Comment #17
mikl CreditAttribution: mikl commentedHere's a Git-formatted version of the patch from #3 that should work with Drush make.
Comment #18
mdupontRerolled patch #17 and included fix from #1264958: Missing hasOwnProperty in jQuery Drilldown. Fixes the issue on my website.
Comment #19
praestigiare CreditAttribution: praestigiare commentedThis script is a bit of a mess. The above patches can solve the array iteration problem, but there are still issues with the cloning of objects. This patch addresses them.
Comment #20
praestigiare CreditAttribution: praestigiare commentedFixed to work with drush make.
Comment #21
praestigiare CreditAttribution: praestigiare commentedSorry, fixed paths.
Comment #22
c4rl CreditAttribution: c4rl commentedComment says we can't use clone.
Comment #23
c4rl CreditAttribution: c4rl commentedDoes this fix it for folks? Sometimes chaining .attr() methods in jQuery for empty attrs doesn't return $(this).
Comment #24
francis55 CreditAttribution: francis55 commented#23 Works for me in IE7, C4rl, thx!
Comment #25
ss81 CreditAttribution: ss81 commented#23 works for me too. Thanks!
Comment #26
c4rl CreditAttribution: c4rl commentedBumparoo
Comment #27
aCCa CreditAttribution: aCCa commentedI had Webform Fieldsets not linkable and not showing inside contents. This was related to conflicts with Admin module and especially with jquery.drilldown.js.
#23 solved also my issue.