Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
clean theme_breakpoints_admin_breakpoints_tablesupport ctools exportables for groupssupport ctools exportables for breakpointsadd setting to manage multipliersallow a user to override breakpoints set by a thememake a setting 'hide overridden' breakpoints, on by default
Comments
Comment #1
Jelle_SGroups are now exportable.
Question:
What to do with breakpoints in groups? Should they be automatically exported and imported when the group is exported? Or should we leave it to the user to export them?
And what if the group contains breakpoints provided by a theme or module? If we choose to export them along with the group, should they be imported with source_type 'custom' or 'module'/'theme'? And what if this module and/or theme is also enabled on the site where the group is imported? Override the breakpoints provided by that theme module (in the rare case that they have a different version of that module/theme so that these breakpoints might have different settings) or leave them as they are?
Comment #2
Jelle_SBreakpoints are now exportable.
Todo:
export and import breakpoints attached to a group when the group is exported
Comment #3
attiks CreditAttribution: attiks commentednew feature request, allow a user to override breakpoints set by a theme
1/ on theme group page add a button 'override theme breakpoints'
2/save all theme breakpoints as custom.theme_key.
3/ change the group to use those breakpoints
4/ hide theme.theme_key breakpoints from the general view (optional)
Comment #4
Jelle_SOverriding is now possible, hiding not yet.
What to do with the following use case:
A theme that defines breakpoints is enabled.
A custom group is created and uses the theme's breakpoints.
A user overrides the breakpoints in the theme group and the theme group now uses the new (overridden) breakpoints.
What to do with the custom group that still uses the 'old/original' breakpoints if the breakpoints are now hidden?
PS:
Optional, as in a setting?
Comment #5
attiks CreditAttribution: attiks commentedfor that use case, don't do anything, it will be hard to predict what the user wants
regarding 4/best to make it a setting 'hide overridden' groups, on by default
Comment #5.0
attiks CreditAttribution: attiks commentedUpdated issue summary.
Comment #5.1
Jelle_SUpdated issue summary.
Comment #6
Jelle_SCleaned theme_breakpoints_admin_breakpoints_table().
Comment #7
Jelle_SAdded form to manage multipliers.
Comment #7.0
Jelle_SUpdated issue summary.
Comment #7.1
Jelle_SUpdated issue summary.
Comment #7.2
Jelle_SUpdated issue summary.
Comment #7.3
Jelle_SUpdated issue summary.
Comment #8
Jelle_SAdded setting 'hide overridden' breakpoints, on by default (need to run update.php, new field 'overridden' added to breakpoint_group table).
Comment #8.0
Jelle_SUpdated issue summary.
Comment #9.0
(not verified) CreditAttribution: commentedUpdated issue summary.