Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This looks fairly silly. :)
I thought this would be easy enough to fix that I could do it myself, but unfortunately I'm stupider than I give myself credit for. :D However, it's a pretty obviously broken-looking thing so unfortunately I have to rate it critical.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1718336-5.patch | 107.19 KB | Wim Leers |
#4 | 1718336-4.patch | 108.03 KB | Wim Leers |
Comments
Comment #1
webchickIf you want to see this in action, http://ftp.drupal.org/files/projects/webchick_profile-7.x-0.1-unstable33... is the latest copy of the Spark distro bundle, and seems to be like working and stuff! :D
Comment #2
Wim LeersI recall seeing this also at some point in time, it was not too hard to solve IIRC.
Comment #3
Wim LeersThis is a recently introduced bug in AE: https://github.com/alohaeditor/Aloha-Editor/issues/659.
I'm working on a temporary patch.
Comment #4
Wim LeersThis ought to work. Massive patch because it is being applied to a minified CSS file.
Comment #5
Wim LeersA change got in that patch that shouldn't have been there.
Comment #6
Wim LeersMore accurate issue title.
Comment #7
Wim LeersDrush make is failing tremendously. I added the patch in #5 to drupal-org.make. But:
WTF?
I updated to Drush 5.4 (from 5.2), `drush cc drush`, `rm -rf ~/.drush/cache/*`, no dice.
So I just hope it'll work better on d.o. Committed to Spark: http://drupalcode.org/project/spark.git/commit/c5f4288.
Comment #8
Wim LeersSet to RTBC to indicate this was fixed with a temporary solution. Real fix will be over at https://github.com/alohaeditor/Aloha-Editor/issues/659.
Comment #9
Wim LeersComment #10
babbage CreditAttribution: babbage commentedWith this patch, these buttons are now labelled "S" for strong and "em" for emphasis. Humans don't use these words. Even on d.o, the rich text editor labels these B and I.
Comment #12
babbage CreditAttribution: babbage commentedOdd, now I see the following:
Comment #13
webchickAre you pulling from the Git version? if so, yeah, this sprint we're actively working on the toolbar to make it way more intuitive. :) #1721838: [META] As a content editor, I would like to have WYSIWYG in a nicely-styled, intuitive toolbar It's a work in progress. What's there now in alpha4 is just Aloha's default behaviour.
Comment #14
babbage CreditAttribution: babbage commentedI'm pulling from the d.o git repository, the -dev version. I realise this is still in utter alpha stage, which makes the lack of documentation understandable, but it is a rather difficult target to get to grips with, since some fixes seem to be being distributed by updating the Spark profile to apply patches to Aloha as a site is built, and so on... which doesn't work so well if you're not recreating a site with the Spark profile. :)
Comment #15
webchickThis is now getting extremely off-topic, but all of the patches that Spark uses to make Edit module work are in its drupal-org.make and drupal-org-core.make files. If you want to use Edit module separately, you can just apply those patches yourself. I recommend sticking with the stable release of Edit module though, as Spark does. We'll roll an alpha4 of Edit when we're done futzing with the toolbar. :)
Comment #16
Wim LeersAloha Editor makes a distinction between bold and strong on the one hand and italics and emphasis on the other hand. I *personally* also think we should ignore bold and italics and just show the bold icon for strong and the italics icon for emphasis, but one *could* validly reason they should be separate.
It's easy enough to override the icon for "strong" with the one for "bold" though. Which is what I think will happen eventually, but this is not a high priority ATM.
Comment #17
MustangGB CreditAttribution: MustangGB commentedI am of the same opinion.
Comment #18
Wim LeersFixed upstream *and* irrelevant to us now because by now we have our own custom UI :)